Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node 10: Cannot read property 'getFileName' of undefined #8

Closed
aleclarson opened this issue Apr 13, 2021 · 0 comments · Fixed by #9
Closed

Node 10: Cannot read property 'getFileName' of undefined #8

aleclarson opened this issue Apr 13, 2021 · 0 comments · Fixed by #9

Comments

@aleclarson
Copy link
Contributor

As evidenced by its type definitions, the caller-callsite package is expected to return undefined in some cases, but this package does not handle that edge case. See the following CI logs for proof.

https://github.com/alloc/indo/runs/2336481322?check_suite_focus=true#step:5:15

Version

  • caller-path@3.0.0
aleclarson added a commit to aleclarson/caller-path that referenced this issue Apr 13, 2021
@aleclarson
fix: handle undefined callsite
0eedf21 
Closes sindresorhus#8
@aleclarson aleclarson mentioned this issue Apr 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix handling of undefined callsite aleclarson/caller-path
1 participant
@aleclarson