Upgrade to Electron 4 and other dependencies

sindresorhus · Dec 20, 2018 · 2744a35 · 2744a35
1 parent 3bd0520
commit 2744a35
Show file tree

Hide file tree

Showing 4 changed files with 61 additions and 48 deletions.
diff --git a/browser.js b/browser.js
@@ -426,7 +426,7 @@ document.addEventListener('DOMContentLoaded', () => {
 	document.body.appendChild(style);
 
 	// Set the zoom factor if it was set before quitting
-	const zoomFactor = config.get('zoomFactor') || 1.0;
+	const zoomFactor = config.get('zoomFactor') || 1;
 	setZoom(zoomFactor);
 
 	// Enable OS specific styles

diff --git a/index.js b/index.js
@@ -189,6 +189,7 @@ function createMainWindow() {
 		webPreferences: {
 			preload: path.join(__dirname, 'browser.js'),
 			nodeIntegration: false,
+			contextIsolation: true,
 			plugins: true
 		}
 	});
@@ -379,10 +380,7 @@ app.on('activate', () => {
 
 app.on('before-quit', () => {
 	isQuitting = true;
-
-	if (!mainWindow.isFullScreen()) {
-		config.set('lastWindowState', mainWindow.getBounds());
-	}
+	config.set('lastWindowState', mainWindow.getNormalBounds());
 });
 
 ipcMain.on('notification', (event, {title, body, icon, silent, fileName}) => {

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -37,11 +37,11 @@
 	},
 	"devDependencies": {
 		"del-cli": "^1.1.0",
-		"electron": "3.0.12",
-		"electron-builder": "20.38.3",
+		"electron": "^4.0.0",
+		"electron-builder": "^20.38.4",
 		"np": "^3.1.0",
 		"stylelint": "^9.8.0",
-		"stylelint-config-xo": "^0.11.0",
+		"stylelint-config-xo": "^0.12.0",
 		"xo": "^0.23.0"
 	},
 	"xo": {