Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow system dark mode #510

Closed
sindresorhus opened this issue Jun 27, 2018 · 3 comments
Closed

Follow system dark mode #510

sindresorhus opened this issue Jun 27, 2018 · 3 comments
Labels
enhancement help wanted

Comments

@sindresorhus
Copy link
Owner

macOS Mojave will have a system-wide dark mode. It would be nice to have an option to follow the system theme.
@CvX
Copy link
Collaborator

CvX commented Jun 27, 2018

(Depends on electron/electron#13387)

@sindresorhus
Copy link
Owner Author

@CvX It's already possible.

We can check whether it's dark mode with systemPreferences.isDarkMode() and detect dark mode changes with systemPreferences.subscribeNotification('AppleInterfaceThemeChangedNotification', () => {}).

@CvX
Copy link
Collaborator

CvX commented Jun 27, 2018

Ah, my bad, I missed the ! when looking at this code: https://github.com/electron/electron/blob/47826a1262ab9d5f25cb9e0128adeb23c5fe8749/atom/browser/api/atom_api_system_preferences.cc#L30-L34 😅

@sergeysova sergeysova mentioned this issue Sep 25, 2018
Closed
@vanejung vanejung mentioned this issue Oct 7, 2018
Merged
@sindresorhus sindresorhus mentioned this issue Jan 7, 2019
Closed
@neegool neegool mentioned this issue Jan 9, 2019
Merged
sindresorhus pushed a commit that referenced this issue Jan 9, 2019
@neegool @sindresorhus
Add setting to follow system dark mode on macOS (#697)
d81ebdd 
Fixes #694
Fixes #510
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@CvX @sindresorhus