New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix "Hide Names and Avatars" #1600
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dusansimic
requested changes
Mar 31, 2021
dusansimic
requested changes
Mar 31, 2021
The conversation name on the sidebar is still not being blurred. Also the package-lock file contains some changes related to webpack. You should revert it to the old state (the one from main branch) just to be safe. |
dusansimic
requested changes
Apr 3, 2021
Co-authored-by: Dušan Simić <dusan.simic1810@gmail.com>
Co-authored-by: Dušan Simić <dusan.simic1810@gmail.com>
I tried your suggestions, it is working for me also. Great that you suggest those changes. |
dusansimic
requested changes
Apr 6, 2021
Co-authored-by: Dušan Simić <dusan.simic1810@gmail.com>
dusansimic
approved these changes
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that that option "Hide Names and Avatars" blur only avatars. Propably @fame1219 had the same problem in ussue #1583
During the tests I also noticed that this option don't work for unread message - don't blur even an avatar.
Closes: #1602