Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Hide Names and Avatars" #1600

Merged
merged 9 commits into from Apr 9, 2021
Merged

Fix "Hide Names and Avatars" #1600

merged 9 commits into from Apr 9, 2021

Conversation

jcabak
Copy link
Contributor

@jcabak jcabak commented Mar 30, 2021

I noticed that that option "Hide Names and Avatars" blur only avatars. Propably @fame1219 had the same problem in ussue #1583

During the tests I also noticed that this option don't work for unread message - don't blur even an avatar.

Closes: #1602

@dusansimic
Copy link
Collaborator

From what I can see, chat name in the top bar and on the right sidebar are still visible. If we want to hide names, then we should hide all of them 😁.

image
image

.gitignore Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
css/new-design/browser.css Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
@dusansimic
Copy link
Collaborator

The conversation name on the sidebar is still not being blurred. Also the package-lock file contains some changes related to webpack. You should revert it to the old state (the one from main branch) just to be safe.

@jcabak
Copy link
Contributor Author

jcabak commented Mar 31, 2021

The conversation name on the sidebar is still not being blurred. Also the package-lock file contains some changes related to webpack. You should revert it to the old state (the one from main branch) just to be safe.
 2021-03-31 o 17 10 47

I tested for several chats, group chats, even in dark mode and everything is blurred. Fix those files, sorry for inconvenience.

css/new-design/browser.css Outdated Show resolved Hide resolved
css/new-design/browser.css Outdated Show resolved Hide resolved
css/new-design/browser.css Outdated Show resolved Hide resolved
jcabak and others added 2 commits April 6, 2021 22:32
Co-authored-by: Dušan Simić <dusan.simic1810@gmail.com>
Co-authored-by: Dušan Simić <dusan.simic1810@gmail.com>
@jcabak
Copy link
Contributor Author

jcabak commented Apr 6, 2021

I tried your suggestions, it is working for me also. Great that you suggest those changes.

css/new-design/browser.css Outdated Show resolved Hide resolved
css/new-design/browser.css Outdated Show resolved Hide resolved
jcabak and others added 2 commits April 7, 2021 00:30
Co-authored-by: Dušan Simić <dusan.simic1810@gmail.com>
@sindresorhus sindresorhus merged commit aa8e2d6 into sindresorhus:main Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide name and avatar don't hide name on v2.52.2
3 participants