Combine system appearance and dark mode settings #1637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dusansimic
requested changes
May 11, 2021
dusansimic
requested changes
May 13, 2021
dusansimic
approved these changes
May 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
api.nativeThemeshould work for non-MacOS platforms. This PR combines thefollowSystemAppearanceanddarkModesettings into a'theme'configuration setting, which mirrors theapi.nativeTheme.themeSourcevariable. However, setting the'dark'or'light'mode should override the system settings.I'm not sure if removing the
darkTheme, which is supposed to force dark mode with some GTK+3 environments, is okay. It could cause some issues with those environments that rely on this configuration.The theme only updates when you click on the window, but I don't think it should be constantly checking while Caprine is in the background.
Tested on: