Select log out as last menu item #1853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Log out is always the last option
dusansimic
approved these changes
Jun 26, 2022
|
@mquevill Would you be interested in joining the project as a maintainer? You have done a lot of great improvements to Caprine. I know this is a little bit late, but I got busy during the summer. |
|
@sindresorhus Yes, I would gladly step in as a maintainer! I've also been a bit busy more recently, but should be able to help out with this project on a regular basis. |
|
@mquevill Awesome :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added functionality to select negatively indexed menu items, since "Log out" is always last in the menu item list.
[Selecting item 11 broke when another "New! Messenger for Windows" item was added to the list. I think that "Log out" will stay as the last item, so this should be more future-proof, but we'll see what the Messenger backend devs do.]