Fix private mode #1884
Merged
Fix private mode #1884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some profile pics that are blured have a cutoff and some don't. Imho, it looks okay and we don't necessarily need to fix that now but it should be something to keep in mind since it's a bit inconsistent. |
dusansimic
approved these changes
Aug 21, 2022
I agree. Is this probably caused from excessive blur on such a small picture? I assume you mean the read indicator picture. |
Both the read indicator and the profile pictures on the left. You can se that my profile picture is blured fine but the picture of the first chat is cut off. On the second chat which is a group chat, you can see that the first profile picture (one on the left) is blured fine but the second one is cut off. The behavior is a bit weird but we could look into that later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes private mode which of course broke after Facebook's latest UI redesign.