Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set window title to "Caprine" #1889

Merged
merged 1 commit into from
Aug 24, 2022
Merged

Set window title to "Caprine" #1889

merged 1 commit into from
Aug 24, 2022

Conversation

lefterisgar
Copy link
Collaborator

I have noticed that by default, messenger.com overrides the window title and sets it to "Messenger". Wouldn't it be better if it was set to "Caprine"?

εικόνα

@lefterisgar lefterisgar merged commit 39f041e into main Aug 24, 2022
@lefterisgar lefterisgar deleted the fix-window-title branch August 24, 2022 07:45
@dusansimic
Copy link
Collaborator

Would this also set the number of unread messages in the title? Something makes me think that was also the behavior of the website title.

@lefterisgar
Copy link
Collaborator Author

Would this also set the number of unread messages in the title? Something makes me think that was also the behavior of the website title.

I see. Let me check that.

@lefterisgar
Copy link
Collaborator Author

Mine stays the same. Always displays "Messenger" regardless of the number of unread messages.

@lefterisgar
Copy link
Collaborator Author

lefterisgar commented Aug 24, 2022

Is this what you mean?
εικόνα

@dusansimic
Copy link
Collaborator

Yes. I thought at some point messenger showed number of unread messages in page title but it might be something on previous design.

@lefterisgar
Copy link
Collaborator Author

Yes. I thought at some point messenger showed number of unread messages in page title but it might be something on previous design.

Maybe. Do you remember seeing it recently?

@dusansimic
Copy link
Collaborator

I'm not sure. It's fine for now :) We can revisit it sometime later as part of working on fixing and implementing notifications and other indicators. It's nothing urgent.

@lefterisgar
Copy link
Collaborator Author

True. The notifications part definitely needs an overhaul!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants