-
-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix new design user menu #1910
Fix new design user menu #1910
Conversation
So here's a progress update. Right now I'm wrestling with typescript config because some packages that I'm bumping in this pr (for example |
One solution that seems to work for some people is splitting the build process for main electron code, preloaded electron code and renderer code. All of those parts are build with vite and tsc (repo). It's worth looking into since it would clean up the code structure a bit and it might be a bit easier to maintain. That would however require adding a few extra steps to the build process. |
A short term solution could be an user set preference for the new desing (if users have the new design, they can just chech the option in advanced settings in menu bar). It would require user intervention but it would fix the issue for now without refactoring the code to vite + tsc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to fix said issues. Looks good to me!
@lefterisgar if you still have access to the old sidebar design, please test weather checking for new design works. It should work okay with openning and closing the preferences and it should remove the |
Unfortunately I don't have access to it anymore. I think it has rolled out to most users out there. |
Is this ready to merge? |
Essentially yes, I'd just like to complete the last task from the list in this pr. I'll see if I can do it today. |
This patch fixes the query selector for user menu on new design.
Checklist:
Closes: #1909
Closes: #1859
Closes: #1918
Closes: #1923