Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix create room icon color in dark mode #1937

Merged
merged 5 commits into from
Oct 16, 2022
Merged

Fix create room icon color in dark mode #1937

merged 5 commits into from
Oct 16, 2022

Conversation

jrafaelsantana
Copy link
Contributor

This patch fixes the messenger group icon color on dark theme.

Before:
image

After:
image

dusansimic
dusansimic requested changes Oct 15, 2022
View reviewed changes
Copy link
Collaborator

@dusansimic dusansimic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a new line to the end of the file. Everything else looks perfect 😁.

dusansimic
dusansimic requested changes Oct 15, 2022
View reviewed changes
css/dark-mode.css Outdated Show resolved Hide resolved
@jrafaelsantana
Copy link
Contributor Author

Done!
Could you tag this PR with the hacktoberfest-accepted label?

Thank you!

@dusansimic dusansimic added the hacktoberfest-accepted PR is accepted for hacktoberfest label Oct 15, 2022
@dusansimic
Copy link
Collaborator

Could you tag this PR with the hacktoberfest-accepted label?

Of course! Just wanted to make sure everything is in order. I'll merge it when CI passes.

@dusansimic
Copy link
Collaborator

@jrafaelsantana could your resolve the conflict?

@dusansimic dusansimic changed the title Fix messenger group icon color Fix create room icon color in dark mode Oct 16, 2022
@dusansimic dusansimic merged commit c9b6077 into sindresorhus:main Oct 16, 2022
@dusansimic
Copy link
Collaborator

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dusansimic dusansimic dusansimic approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted PR is accepted for hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jrafaelsantana @dusansimic