Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed image waiting method on fullPage option, +TravisCI fix #49

Closed
wants to merge 8 commits into from
Closed

Changed image waiting method on fullPage option, +TravisCI fix #49

wants to merge 8 commits into from

Commits on Aug 11, 2020

  1. Changed image waiting method as per 

    sindresorhus#40 (comment)
    @sgtrusty
    sgtrusty committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    2fc50fa View commit details
    Browse the repository at this point in the history

  2. Fixed an issue with async func missing

    @sgtrusty
    sgtrusty committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    de2cbda View commit details
    Browse the repository at this point in the history

  3. ESLint skipped feats

    @sgtrusty
    sgtrusty committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    58c3902 View commit details
    Browse the repository at this point in the history

  4. ESLint changes... 

    Trying to setup my local environment, quick fixes lol...
    @sgtrusty
    sgtrusty committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    40b4286 View commit details
    Browse the repository at this point in the history

  5. ESlint bruh 

      ✖  348:1   Trailing spaces not allowed.                                         no-trailing-spaces
    @sgtrusty
    sgtrusty committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    8be2e16 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2020

  1. Promisify & eslint-disable-next-line from blocks

    @sgtrusty
    sgtrusty committed Aug 14, 2020
    Configuration menu
    Copy the full SHA
    bb94ae2 View commit details
    Browse the repository at this point in the history

  2. Fixed issues not allowing real use case scenario 

    `const navigationPromise = page.waitForNavigation({waitUntil: 'networkidle0'});`
Temporarily removed ... Need to find an alternative to this. I tried with 'networkidle2' but it wouldn't finish loading at all. Maybe check `document.images` or other resources (on or off screen) to see if proceed with scrolling.
    @sgtrusty
    sgtrusty committed Aug 14, 2020
    Configuration menu
    Copy the full SHA
    84488c2 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2020

  1. Changed Promise.all from individual promises 

    Added Promise.race and filtering based on incompleted images to run events on
    @sgtrusty
    sgtrusty committed Aug 29, 2020
    Configuration menu
    Copy the full SHA
    6d0fe16 View commit details
    Browse the repository at this point in the history