Add preloadFunction option
#76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
index.d.ts
Outdated
| @@ -164,6 +164,11 @@ declare namespace captureWebsite { | |||
| */ | |||
| readonly isJavaScriptEnabled?: boolean; | |||
|
|
|||
| /** | |||
| Inject a function to be executed prior to navigation; useful for [altering the JavaScript environment](https://github.com/puppeteer/puppeteer/blob/main/docs/api.md#pageevaluateonnewdocumentpagefunction-args). | |||
There was a problem hiding this comment.
The readme and index.d.ts docs should be in sync.
readme.md
Outdated
| Inject a function to be executed prior to navigation. | ||
|
|
||
| This can be useful for [altering the JavaScript environment](https://github.com/puppeteer/puppeteer/blob/main/docs/api.md#pageevaluateonnewdocumentpagefunction-args). For example, you could define a global method on the `window`, overwrite `navigator.languages` to change the language presented by the browser, or mock `Math.random` to return a fixed value. | ||
|
|
||
| *This option applies only to `captureWebsite.file()`.* |
brandon93s
commented
Feb 12, 2021
| This can be useful for [altering the JavaScript environment](https://github.com/puppeteer/puppeteer/blob/main/docs/api.md#pageevaluateonnewdocumentpagefunction-args). For example, you could define a global method on the `window`, overwrite `navigator.languages` to change the language presented by the browser, or mock `Math.random` to return a fixed value. | ||
| */ | ||
| readonly preloadFunction?: EvaluateFn; | ||
|
|
|
Documentation has been cleaned up. |
https://github.com/sindresorhus/capture-website/releases/tag/v1.4.0 Can be done now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates from #66; Fixes #48.
I'll follow with corresponding additions to https://github.com/sindresorhus/capture-website-cli.