Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Latest spinners aren't defined in TypeScript #55

Closed
excalbian opened this issue Sep 9, 2021 · 0 comments · Fixed by #56
Closed

Latest spinners aren't defined in TypeScript #55

excalbian opened this issue Sep 9, 2021 · 0 comments · Fixed by #56

Comments

@excalbian
Copy link

I was trying to use one of the newest (emoji) spinners from #46 but since I'm using a TypeScript project, the index.d.ts doesn't list them as valid values, and my code kept failing ☹️.

Will create a PR in a moment to fix this, if it is accepted.
lxsmnsyc added a commit to lxsmnsyc/cli-spinners that referenced this issue Oct 1, 2021
@lxsmnsyc
Add missing SpinnerName (sindresorhus#55)
8862795
@lxsmnsyc lxsmnsyc mentioned this issue Oct 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add missing spinners to TypeScript types lxsmnsyc/cli-spinners
1 participant
@excalbian