Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameter definition out of order for onDidChange callback #69

Closed
scottbot95 opened this issue Apr 22, 2019 · 0 comments · Fixed by #70
Closed

Parameter definition out of order for onDidChange callback #69

scottbot95 opened this issue Apr 22, 2019 · 0 comments · Fixed by #70

Comments

@scottbot95
Copy link
Contributor

The typescript declaration file lists the parameters for the onDidChange callback as oldValue, newValue when it should be newValue, oldValue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix parameter name order for onDidChange callback scottbot95/conf
1 participant
@scottbot95