Replace deprecated crypto methods #72
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -211,7 +211,10 @@ class Conf { | |||
|
|
|||
| if (this.encryptionKey) { | |||
| try { | |||
| const decipher = crypto.createDecipher(encryptionAlgorithm, this.encryptionKey); | |||
| const iv = Buffer.alloc(16); | |||
| const key = crypto.pbkdf2Sync(this.encryptionKey, iv.toString(), 10000, 32, 'sha512'); | |||
There was a problem hiding this comment.
I think this will break existing uses where the encryptionKey is not using pbkdf2Sync.
There was a problem hiding this comment.
According to my tries and by nodejs/node#16746 it may impossible to make this upgrade without any harm since key patrameter in createCipherkv method require fixed length, so any previous key that does not match createCipherIv criteria will produce an error 😕
sindresorhus
changed the title
|
Closing this in favor of #76 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to fix sindresorhus/electron-store#67, but the fix had to be done here.
Since the README states :
I permitted myself to use a non-random IV.
Test results
Node 11.15.0Node 10.15.3
Node 8.16.0
Also I would be very grateful if you could indicate me the next step so I can help you resolve sindresorhus/electron-store#67
Thanks in advance !