Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add directoryMode option #44

Merged
merged 6 commits into from Jun 13, 2021
Merged

Add directoryMode option #44

merged 6 commits into from Jun 13, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jun 10, 2021

Adds an option directoryMode which enables controlling permissions of implicitly created directories.

@ghost
Copy link
Author

ghost commented Jun 10, 2021

Linting and tests currently fail on main, but this adds no new failures. Running tests manually shows only the same failure as main. The new tests for the added option all pass.

$ ava


  1 test failed

  async › rethrow read after open errors

  /home/user/patch/cp-file/test/async.js:266

   265:   t.is(error.errno, readError.errno, error.message);
   266:   t.is(calledWriteEnd, 1);                          
   267:                                                     

  Difference:

  - 2
  + 1


Type tests also pass.

$ npm run type-test

> cp-file@9.0.0 test
> tsd


@ghost
Copy link
Author

ghost commented Jun 11, 2021

Updated this against the notes on the move-file patch.

@sindresorhus sindresorhus merged commit 4eb8f47 into sindresorhus:main Jun 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant