onProgress option added #52
Conversation
|
I don't know how to correctly reflect the changes for |
index.js
Outdated
| @@ -65,6 +65,10 @@ const cpFile = (sourcePath, destinationPath, options) => { | |||
| const progressEmitter = new ProgressEmitter(path.resolve(sourcePath), path.resolve(destinationPath)); | |||
| const promise = cpFileAsync(sourcePath, destinationPath, options, progressEmitter); | |||
|
|
|||
| if (typeof options.onProgress === 'function') { | |||
| progressEmitter.on('progress', options.onProgress); | |||
There was a problem hiding this comment.
It should be the inverse. .on should use onProgress. This would make it easier to remove the deprecated .on method in a future release.
There was a problem hiding this comment.
Sorry I don't understand. How can promise.on use options.onProgress?
There was a problem hiding this comment.
Pretend that promise.on and progressEmitter doesn't exist and try to implement options.onProgress. That what the implementation should be.
There was a problem hiding this comment.
It makes sense but promise.on handles it on a different phase (chained). I can try to rewrite it this week.
There was a problem hiding this comment.
I've found a way to cover deprecated implementation through options mutation but I am not sure about that.
|
Can you fix the merge conflict? |
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
|
Friendly bump :) |
Fixes #51
.on()has been deprecatedonProgressoption (async mode only)