parents, dest handling with cwd and handling of absolute paths #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schnittstabil
force-pushed
the
kevva-parents
branch
from
671a905
to
25e9c9d
Compare
|
|
||
| if (!pathIsAbsolute(dest) && opts.cwd) { | ||
| dest = path.join(opts.cwd, dest); | ||
| } |
There was a problem hiding this comment.
I think you can use path.resolve instead so don't have to check if it's absolute.
There was a problem hiding this comment.
Nice, I hadn't thought of that. It is a pity that path.resolve(undefined, srcPath) does not work...
|
Lgtm, @kevva? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is on top of @kevva PR #4.
To sum it up:
About 2.:
should copy the file
cwd/hello.jstocwd/dest/hello.js, but copies todest/hello.jsatm.