-
-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mount device custom icon generation #33
Add mount device custom icon generation #33
Conversation
You need to mention the |
@manrueda Can you add commits instead of squashing and force pushing so I can see what changed? I will squash on merge anyway. |
Sure (its done). About the icon for the dmg file. Looks like macos had all the right tools to do it, but they removed one time ago and not the only solution is some python script. |
How about bundling the |
You need to add the disk icon to |
Disk icon added |
Any thoughts on #33 (comment) ? |
I can give it a try, i don't have much experience with releasing binaries on macOS. Because this library already only works on macOS for obvios reasons should be on to bundle the compiled binary, right? |
Just pushed an implementation of |
Works great! Thanks for doing this :) |
During the DMG generation (if gm is installed), a new icon will be created using the OS mounted drive icon and the apps icon. It will apply a perspective and size correction on the app icon before the composition.
Example:
![image](https://user-images.githubusercontent.com/2576444/51797684-f0032780-21d5-11e9-8515-55d589a3070c.png)
Fixes #16