Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML vs Text value #2

Closed
fregante opened this issue Jan 16, 2018 · 1 comment
Closed

HTML vs Text value #2

fregante opened this issue Jan 16, 2018 · 1 comment
Labels
enhancement help wanted

Comments

@fregante
Copy link
Collaborator

create-html-element only supports innerHTML via the prop value, whose name doesn't make this clear.

There should probably be a way to differentiate innerHTML from textContent, perhaps by using html and text, or literally innerHTML and textContent.

textContent would be escaped by escape-goat
@fregante fregante mentioned this issue Jan 16, 2018
Closed
@sindresorhus
Copy link
Owner

Removing the value option and replacing it with html and text options makes sense to me.

kevva added a commit to kevva/create-html-element that referenced this issue Mar 5, 2018
@kevva
Replace value option with html and text
4eaf9a5 
Fixes sindresorhus#2.
@kevva kevva mentioned this issue Mar 5, 2018
Merged
sindresorhus pushed a commit that referenced this issue May 1, 2018
@kevva @sindresorhus
Replace value option with html and text (#3)
d24676e 
Fixes #2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sindresorhus @fregante