Fix Homebrew builds #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anderscarling
force-pushed
the
homebrew-arm64-builds
branch
from
4ff5a37
to
022e8fa
Compare
|
I'm fine with this, but you have to update the readme. |
|
@sindresorhus Build instructions in readme are updated, let me know if you think they need further adjustments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the copying of build product to ./bin/dark-mode from a build phase to the ./build script. This is done to ensure we never copy a non-codesigned binary to ./bin - which is what seems to be the cause of #19.
This would work even without removing the build phase, as the copy from ./build will simply overwrite it. I'm not sure the build phase copy is really useful for other things than release though, and it's a bit quirky - basically it seems to never be codesigned on first build (e.g. after a "Clean build folder" + "build"), but it will then be codesinged on subsequent builds.
If you would like me to update the PR to keep the build phase in, let me know and i'll fix that.
Fixes #19