Remove redundant code #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
approved these changes
Feb 6, 2017
| switch arguments.stringAt(0) { | ||
| case "--help": | ||
| switch arguments.first { | ||
| case "--help"?: |
There was a problem hiding this comment.
I initially had it like this, but I foolishly used switch arguments[0] which didn't work. Thanks for showing me the correct way.
| @@ -8,7 +8,7 @@ struct DarkMode { | |||
| } | |||
|
|
|||
| static func toggle(force: Bool? = nil) { | |||
| let val = force != nil ? String(force!) : "not dark mode" | |||
| let val = force.map(String.init) ?? "not dark mode" | |||
|
Thank you for the review! :) I really appreciate it. I'm just starting out with Swift, so I'm very keen on learning best practices and what to avoid. I could also use a review of the Swift part of wulkano/Aperture#26 if you have any interest. No worries if not though. |
|
Cool 👍 Will have a look at wulkano/Aperture#26 later! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed some redundant code and avoided some force unwrapping.