Ignore unexpected EOF errors #1
Conversation
|
|
||
| res.emit('error', err); | ||
| }); | ||
|
|
||
| res.on('close', function () { | ||
| unzip.emit('close'); |
There was a problem hiding this comment.
Btw, not sure you should use unzip.emit('close') here, end is probably better.
There was a problem hiding this comment.
Why is it better? I've yet to figure out the difference. Wouldn't res.end() be more correct then?
There was a problem hiding this comment.
Ugh, seems there's no official way: http://stackoverflow.com/questions/19277094/how-to-close-a-readable-stream-before-end Node.js streams really are the worst...
There was a problem hiding this comment.
I've encountered less inconsistencies when using end rather than close. I actually tested using res.emit('close') at first, but then it never exited.
Wouldn't res.end() be more correct then?
Yes. If it's a writable stream, res.end() wouldn't work since it's a readable.
There was a problem hiding this comment.
I'll do this in a major bump, just to be sure.
Fixes sindresorhus/got#224.