Fix Electron 12 compatibility #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing remote to be compatible with Electron 12 and removing renderer support so we don't need to implement workarounds for use of remote.
sindresorhus
requested changes
Apr 29, 2021
sindresorhus
changed the title
Fix grammar in error message and readme. Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
Check for renderer process only when creating context menu, not when require-ing the module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing remote to be compatible with Electron 12 and removing renderer support so we don't need to implement workarounds for remote module.
Closes: #133