Fix TypeScript compile error with Electron v17 #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhysd
added a commit
to rhysd/tweet-app
that referenced
this pull request
Feb 10, 2022
AtofStryker
added a commit
to cypress-io/cypress
that referenced
this pull request
Jul 21, 2023
…ixed the issue we were patching in sindresorhus/electron-context-menu#156, so the patch can be deleted
AtofStryker
added a commit
to cypress-io/cypress
that referenced
this pull request
Jul 23, 2023
…ixed the issue we were patching in sindresorhus/electron-context-menu#156, so the patch can be deleted
AtofStryker
added a commit
to cypress-io/cypress
that referenced
this pull request
Jul 24, 2023
…ixed the issue we were patching in sindresorhus/electron-context-menu#156, so the patch can be deleted
AtofStryker
added a commit
to cypress-io/cypress
that referenced
this pull request
Jul 25, 2023
…ixed the issue we were patching in sindresorhus/electron-context-menu#156, so the patch can be deleted
3 tasks
AtofStryker
added a commit
to cypress-io/cypress
that referenced
this pull request
Jul 26, 2023
* chore: update electron-context-menu to 3.6.1. electron-context-menu fixed the issue we were patching in sindresorhus/electron-context-menu#156, so the patch can be deleted * chore: update electron/get from v1 to v2. v2 drops node 12 so nothing breaking on our end * chore: update electron-builder to ^v23.6.0 (checkTs passing) * chore: upgrade electron packager to v16 * update electron-packager from v16 to v17 * run binary jobs for electron updates [run ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When I upgraded Electron dependency to the latest version v17, compiling electron-context-menu with TypeScript compiler caused the following error:
After some investigation, I realized that
WebviewTagis no longer defined inelectronmodule.Since the compile error happens in dependency's type definition file, there is no way to fix it from a user. So this is a blocker to upgrade Electron version to the latest for me.
Fix
Instead of importing it from
electronmodule, referring theWebviewTagclass defined inElectronnamespace directly worked fine.Fixes #148