Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Select All menu item #118 #160

Merged
merged 4 commits into from Aug 11, 2022
Merged

Conversation

hns258
Copy link
Contributor

@hns258 hns258 commented Aug 8, 2022

An implementation for #118 Missing Select All?, defaulting to only show if non-macOS (but can be forced to be shown/hidden via the showSelectAll option).

Placing Select All below Paste to mimic Edit sub-menu in Electron (2nd image) and most other context menus.

Screen Shot 2022-08-09 at 10 20 02 AM

Screen Shot 2022-08-09 at 9 59 11 AM


Fixes #118

@hns258 hns258 changed the title Add "Select All" menu item (https://github.com/sindresorhus/electron-context-menu/issues/118) Add "Select All" menu item #118 Aug 8, 2022
readme.md Outdated Show resolved Hide resolved
@hns258 hns258 marked this pull request as ready for review August 8, 2022 23:00
@hns258 hns258 marked this pull request as draft August 9, 2022 01:40
@hns258 hns258 changed the title Add "Select All" menu item #118 Add Select All menu item #118 Aug 9, 2022
@hns258 hns258 marked this pull request as ready for review August 9, 2022 02:26
@hns258 hns258 marked this pull request as draft August 9, 2022 02:59
@hns258 hns258 marked this pull request as ready for review August 9, 2022 15:05
@sindresorhus sindresorhus merged commit 3efba17 into sindresorhus:main Aug 11, 2022
hns258 added a commit to hns258/electron-context-menu that referenced this pull request Aug 14, 2022
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
smartfrigde added a commit to ArmCord/electron-context-menu that referenced this pull request Aug 25, 2022
* Add `showSelectAll` option (sindresorhus#160)

Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>

* 3.4.0

* Fix typo in readme example (sindresorhus#162)

* Meta tweaks

* Add menu items to save and copy video (sindresorhus#161)

* 3.5.0

Co-authored-by: hns258 <ncz258@gmail.com>
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
Co-authored-by: tauraloke <tauraloke@gmail.com>
Co-authored-by: andy wu <and80506@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Select All?
2 participants