New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: inspect element not working in BrowserView #167

Merged

sindresorhus merged 1 commit into sindresorhus:main from yocontra:patch-1

Dec 3, 2022

Contributor

yocontra commented Dec 1, 2022

Previously this would throw and crash the process:

TypeError: win.inspectElement is not a function
    at click (/Users/contra/Projects/canopy-app/.webpack/main/index.js:19079:10)
    at MenuItem.click (node:electron/js2c/browser_init:73:1906)
    at a._executeCommand (node:electron/js2c/browser_init:81:2453)

This change makes it work, since inspectElement is on the webContents in a BrowserView


          fix: inspect element not working in BrowserView

823d4d7

sindresorhus merged commit cc69dea into sindresorhus:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment