Fix TypeScript types

[thegnuu]

Completed was not recognised as a valid type and I was not able to find something within electron or your library which matches this term.

So I added the types manually based on the onCompleted call from index.js.

The current version was not working in my typescript project, at least not without additional changes to add this Completed type.

[sindresorhus]

// @paviro

[paviro]

Will check asap (probably tomorrow).

[paviro]

Okay now I am really confused what I did there.
readonly onTotalProgress?: (file: File) => void; should be readonly onTotalProgress?: (file: Progress) => void;
and readonly onCompleted?: (completed: Completed) => void; should be readonly onCompleted?: (completed: File) => void;
If I am not completely mistaken.

[thegnuu]

@paviro looking at it now you are right yes, I don't know how I missed the File interface and copied the whole thing. I was not able to test the rest of the interfaces since I already failed on the missing Completed interface.

readonly onCompleted?: (completed: File) => void looks totally fine for me.

readonly onTotalProgress?: (file: Progress) => void;: I guess the param should be renamed like readonly onTotalProgress?: (progress: Progress) => void;, but yes, it should be Progress and not File based on the code.

Do you want me to change it and update the PR or do you want to change it directly within the main branch and close this PR?

[paviro]

I don't really have any experience with typescript which is also why I missed this. So if you can I would be really thankful if you could double check that the other functions I introduced in bd55e77 work as expected when using typescript.

The last question is probably for @sindresorhus as I don't have access to the repo.

[thegnuu]

I can easily to this if you want! But I guess it will take me a few days, I'm kinda busy atm.

@sindresorhus I don't know how used you are to typescript, if you'd like I can as well rewrite the project to typescript to enable type checking and to allow the automatic generation of types. But I totally understand if you want to stick to js :)

[sindresorhus]

I don't know how used you are to typescript, if you'd like I can as well rewrite the project to typescript to enable type checking and to allow the automatic generation of types. But I totally understand if you want to stick to js :)

I have a lot of experience with TS, which is exactly why I prefer to stay with JS.

[thegnuu]

Totally fine with that. I updated my PR according to the changes discussed.