Support non-primitive values

[Richienb]

Since this method replaces the normal serialization in order to work, we might want to store this behind an option instead. It might also make sense to move this to conf instead.

Fixes: #18

---

IssueHunt Summary

[sindresorhus]

It should be implemented in Conf first, yes. I'm also not entirely sold on the current implementation as it makes the JSON store file just store a lot of Base64 binary items, which makes debugging really difficult.

[Richienb]

What about serialize-javascript?

[sindresorhus]

Also see, sindresorhus/conf#89. I'm not entirely happy with that way either.

[sindresorhus]

What about serialize-javascript?

From a quick glance, it has a lot of issues. I think ideally, we would only use v8 for the types that are not natively supported by JSON. But we then need to also store in a meta-field which types should use native serialization and which should go through v8.

[sindresorhus]

But since we need to store it in a meta-field anyway, we could use a nicer human-friendly representation. Which brings us back to sindresorhus/conf#89.

[Richienb]

Perhaps the serialiser can decide on what the meta-field should be called to avoid limitations on naming and serialise with v8.

The deserialiser can then look at the JSON and given the same set of rules the serialiser used, discover the name of the meta-field and reverse what it did.

[sindresorhus]

Perhaps the serialiser can decide on what the meta-field should be called to avoid limitations on naming and serialise with v8.

Not sure I understand what you mean. The meta-field name would be hard-coded. It would contain the same structure as the top-level ones. See the discussion in sindresorhus/conf#89.

[Cordelro]

Payment

[Cordelro]

#179

[Cordelro]

#189

[Cordelro]

#199

[Richienb]

New plan: Make the replacer in JSON.stringify and the reviver in JSON.parse send non-primatives through the v8 serialize and deserialize functions so that they end up with a 2-part string as a value like this: __conf-${data}.

[Richienb]

Continued in sindresorhus/conf#154