Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make emit() wait for all listeners to settle #19

Closed
wants to merge 3 commits into from
Closed

Make emit() wait for all listeners to settle #19

wants to merge 3 commits into from

Commits on Feb 17, 2018

  1. [WIP] emit waits for all listeners to settle

    @dinoboff
    dinoboff committed Feb 17, 2018
    Configuration menu
    Copy the full SHA
    a554529 View commit details
    Browse the repository at this point in the history

  2. emit() waits for all listeners to settle 

    * The promise returned by emit() settles once all listeners do
* If no listener threw an exception, the promise is fulfilled with
`undefined`
* Otherwise it's rejected with the first exception
    @novemberborn @dinoboff
    novemberborn authored and dinoboff committed Feb 17, 2018
    Configuration menu
    Copy the full SHA
    e15aca2 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2018

  1. emit never reject. 

    - catch listeners’ errors.
- let the host emit an unhandled rejection event for each listener error.
    @dinoboff
    dinoboff committed Feb 22, 2018
    Configuration menu
    Copy the full SHA
    d08a21b View commit details
    Browse the repository at this point in the history