Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, you could do:
This is incorrect, since
e.emit('baz')
is allowed.Note that TypeScript can't express the type of
eventData
based oneventName
. ThuseventData
will be the union of'bar' | undefined
. I guess it's an encouragement for adding regular listeners instead.I also noticed that
new Emittery.Typed<{}, true>()
was allowed. Empty event names must still be strings./cc @dinoboff.