Fix support for typed subscriptions for multiple event names for .on()
#84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
reviewed
May 1, 2021
|
Can you add it to all the methods that accept it? See: https://github.com/sindresorhus/emittery/pull/82/files |
I'm unsure about how to add the tests. But I added the type into the other methods |
|
They need to be tested for this to be merged. |
Tests added! |
|
Tests are failing. Please always run |
|
I'm getting issues with pEvent compatibility, the emitter in pEvent don't expect the emitter methods to receive an array |
sindresorhus
changed the title
.on()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #82