Escape - in a way that’s compatible with PCRE (#23)

sindresorhus · Apr 23, 2020 · ec45c70 · denilsonsa · Jun 9, 2020 · sindresorhus
1 parent d248d82
commit ec45c70
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/index.js b/index.js
@@ -9,5 +9,5 @@ module.exports = string => {
 	// Use a simple backslash escape when it’s always valid, and a \unnnn escape when the simpler form would be disallowed by Unicode patterns’ stricter grammar.
 	return string
 		.replace(/[|\\{}()[\]^$+*?.]/g, '\\$&')
-		.replace(/-/g, '\\u002d');
+		.replace(/-/g, '\\x2d');
 };
diff --git a/test.js b/test.js
@@ -8,10 +8,10 @@ test('main', t => {
 	);
 });
 
-test('escapes `-`', t => {
+test('escapes `-` in a way compatible with PCRE', t => {
 	t.is(
 		escapeStringRegexp('foo - bar'),
-		'foo \\u002d bar'
+		'foo \\x2d bar'
 	);
 });