Escape - in a way that’s compatible with Unicode patterns
#21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regex using the `u` flag is stricter about unnecessary escapes, and disallows `\-` outside of character classes. `\x2d` means a literal hyphen both inside and outside character classes, both with and without the `u` flag. Fixes #20.
charmander
commented
Mar 14, 2020
Co-Authored-By: Sindre Sorhus <sindresorhus@gmail.com>
|
@sindresorhus That kind of comment? |
|
Last, can you add a test that just shows that it now works with |
|
@sindresorhus Added! |
charmander
added a commit
to charmander/escape-string-regexp
that referenced
this pull request
Apr 16, 2020
Original form of sindresorhus#21, plus test description. Fixes sindresorhus#22.
This was referenced Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regex using the
uflag is stricter about unnecessary escapes, and disallows\-outside of character classes.\x2dmeans a literal hyphen both inside and outside character classes, both with and without theuflag.Fixes #20.