Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only underline filename in header #25

Merged
merged 2 commits into from
Sep 5, 2017
Merged

Only underline filename in header #25

merged 2 commits into from
Sep 5, 2017

Conversation

calebeby
Copy link
Contributor

@calebeby calebeby commented Sep 3, 2017

I think it looks prettier this way.

SamVerschueren
SamVerschueren approved these changes Sep 4, 2017
View reviewed changes
Copy link
Contributor

@SamVerschueren SamVerschueren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, in the cases that hidden is not supported, I believe it looks better.

Care to share a quick screenshot of the differences? So that every review quickly sees what changed.

@calebeby
Copy link
Contributor Author

calebeby commented Sep 4, 2017

Before
After

@sindresorhus sindresorhus merged commit 6c1adff into sindresorhus:master Sep 5, 2017
@sindresorhus
Copy link
Owner

Yup. Looks better. Thanks @calebeby :)

@calebeby calebeby deleted the patch-1 branch September 5, 2017 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamVerschueren SamVerschueren SamVerschueren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@calebeby @sindresorhus @SamVerschueren