Add TypeScript definition #50
Conversation
|
Thanks for creating a TypeScript definition. 🙌 Can you follow this styleguide? Some examples: |
|
Tried my best :-) |
|
Ok, not the best. Adding few things - like tds test... |
sindresorhus
changed the title
|
Well, the best would be to update @types/eslint first and then make format of type Formatter. I've created PR at DefinitelyTYped for that - will modify it here once is approved/merged there. |
|
I hope it's better now. |
| @param results - Lint result for the individual files. | ||
| @param data - Extended information related to the analysis results. | ||
| @returns The formatted output. | ||
| */ |
There was a problem hiding this comment.
I think the doc comment should be added to the type in DefinitelyTyped. That way every consumer benefits from it and it can be properly kept in sync with ESLint changes.
There was a problem hiding this comment.
Good idea. Please, go ahead and create PR.
There was a problem hiding this comment.
I'm sorry, but I don't have time to do that. You are the one that wants this to be merged.
Trivial declaration file for typescript so VS Code won't yell while editing webpack config file...