Simplify no-unreadable-array-destructuring

sindresorhus · Mar 17, 2020 · 1f25046 · 1f25046
1 parent 74ddbf9
commit 1f25046
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 13 deletions.
diff --git a/rules/no-unreadable-array-destructuring.js b/rules/no-unreadable-array-destructuring.js
@@ -1,22 +1,17 @@
 'use strict';
 const getDocumentationUrl = require('./utils/get-documentation-url');
 
-const isCommaFollowedWithComma = (element, index, array) => {
-	return element === null && array[index + 1] === null;
-};
+const message = 'Array destructuring may not contain consecutive ignored values.';
+const isCommaFollowedWithComma = (element, index, array) =>
+	element === null && array[index + 1] === null;
 
 const create = context => {
 	return {
-		ArrayPattern(node) {
-			const {elements} = node;
-			if (!elements || elements.length === 0) {
-				return;
-			}
-
-			if (elements.some(isCommaFollowedWithComma)) {
+		'ArrayPattern[elements.length>1]': node => {
+			if (node.elements.some(isCommaFollowedWithComma)) {
 				context.report({
 					node,
-					message: 'Array destructuring may not contain consecutive ignored values.'
+					message
 				});
 			}
 		}

diff --git a/test/no-unreadable-array-destructuring.js b/test/no-unreadable-array-destructuring.js
@@ -30,7 +30,9 @@ ruleTester.run('no-unreadable-array-destructuring', rule, {
 		'function foo([bar,]) {}',
 		'function foo([bar,,]) {}',
 		'function foo([bar,, baz,, qux]) {}',
-		'const [, ...rest] = parts;'
+		'const [, ...rest] = parts;',
+		// This is stupid, but valid code
+		'const [,] = parts;'
 	],
 	invalid: [
 		{
@@ -68,6 +70,11 @@ ruleTester.run('no-unreadable-array-destructuring', rule, {
 		{
 			code: 'const [,,...rest] = parts;',
 			errors
-		}
+		},
+		// This is stupid, but valid code
+		{
+			code: 'const [,,] = parts;',
+			errors
+		},
 	]
 });