Allow rule.create to return undefined (#1912)

sindresorhus · Sep 21, 2022 · 4b61c92 · 4b61c92
1 parent 7c8abf5
commit 4b61c92
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 8 deletions.
diff --git a/rules/filename-case.js b/rules/filename-case.js
@@ -147,7 +147,7 @@ const create = context => {
 	const filenameWithExtension = context.getPhysicalFilename();
 
 	if (filenameWithExtension === '<input>' || filenameWithExtension === '<text>') {
-		return {};
+		return;
 	}
 
 	return {

diff --git a/rules/no-empty-file.js b/rules/no-empty-file.js
@@ -20,7 +20,7 @@ const create = context => {
 	const filename = context.getPhysicalFilename().toLowerCase();
 
 	if (!/\.(?:js|mjs|cjs|ts|mts|cts)$/.test(filename)) {
-		return {};
+		return;
 	}
 
 	return {

diff --git a/rules/prefer-module.js b/rules/prefer-module.js
@@ -218,7 +218,7 @@ function create(context) {
 	const filename = context.getFilename().toLowerCase();
 
 	if (filename.endsWith('.cjs')) {
-		return {};
+		return;
 	}
 
 	const sourceCode = context.getSourceCode();

diff --git a/rules/string-content.js b/rules/string-content.js
@@ -70,7 +70,7 @@ const create = context => {
 	const replacements = getReplacements(patterns);
 
 	if (replacements.length === 0) {
-		return {};
+		return;
 	}
 
 	return {

diff --git a/rules/utils/rule.js b/rules/utils/rule.js
@@ -71,10 +71,18 @@ function reportProblems(create) {
 		return create;
 	}
 
-	const wrapped = context => Object.fromEntries(
-		Object.entries(create(context))
-			.map(([selector, listener]) => [selector, reportListenerProblems(listener, context)]),
-	);
+	const wrapped = context => {
+		const listeners = create(context);
+
+		if (!listeners) {
+			return {};
+		}
+
+		return Object.fromEntries(
+			Object.entries(listeners)
+				.map(([selector, listener]) => [selector, reportListenerProblems(listener, context)]),
+		);
+	};
 
 	wrappedFunctions.add(wrapped);