Fix escape-case missing cases (#534)

sindresorhus · Feb 12, 2020 · 892f054 · 892f054
1 parent eb1923d
commit 892f054
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 2 deletions.
diff --git a/rules/escape-case.js b/rules/escape-case.js
@@ -7,8 +7,8 @@ const {
 const getDocumentationUrl = require('./utils/get-documentation-url');
 const replaceTemplateElement = require('./utils/replace-template-element');
 
-const escapeWithLowercase = /(?<=(?:^|[^\\])(?:\\\\)*\\)(?<data>x[\da-f]{2}|u[\da-f]{4}|u{[\da-f]+})/;
-const escapePatternWithLowercase = /(?<=(?:^|[^\\])(?:\\\\)*\\)(?<data>x[\da-f]{2}|u[\da-f]{4}|u{[\da-f]+}|c[a-z])/;
+const escapeWithLowercase = /(?<=(?:^|[^\\])(?:\\\\)*\\)(?<data>x[\dA-Fa-f]{2}|u[\dA-Fa-f]{4}|u{[\dA-Fa-f]+})/;
+const escapePatternWithLowercase = /(?<=(?:^|[^\\])(?:\\\\)*\\)(?<data>x[\dA-Fa-f]{2}|u[\dA-Fa-f]{4}|u{[\dA-Fa-f]+}|c[a-z])/;
 const hasLowercaseCharacter = /[a-z]+/;
 const message = 'Use uppercase characters for the value of the escape sequence.';
 

diff --git a/test/escape-case.js b/test/escape-case.js
@@ -72,6 +72,22 @@ ruleTester.run('escape-case', rule, {
 			errors,
 			output: 'const foo = "\\xA9";'
 		},
+		// Mixed cases
+		{
+			code: 'const foo = "\\xAa";',
+			errors,
+			output: 'const foo = "\\xAA";'
+		},
+		{
+			code: 'const foo = "\\uAaAa";',
+			errors,
+			output: 'const foo = "\\uAAAA";'
+		},
+		{
+			code: 'const foo = "\\u{AaAa}";',
+			errors,
+			output: 'const foo = "\\u{AAAA}";'
+		},
 		{
 			code: 'const foo = "\\ud834";',
 			errors,