Remove use of deprecated methods, require eslint>=8.40.0 (#2081)

Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
sindresorhus · May 8, 2023 · db4f78a · db4f78a
1 parent 6f05ddc
commit db4f78a
Show file tree

Hide file tree

Showing 87 changed files with 91 additions and 92 deletions.
diff --git a/package.json b/package.json
@@ -94,7 +94,7 @@
 		"yaml": "^2.2.1"
 	},
 	"peerDependencies": {
-		"eslint": ">=8.38.0"
+		"eslint": ">=8.40.0"
 	},
 	"ava": {
 		"files": [

diff --git a/rules/catch-error-name.js b/rules/catch-error-name.js
@@ -60,7 +60,7 @@ const create = context => {
 				return;
 			}
 
-			const scope = context.getSourceCode().getScope(node);
+			const scope = context.sourceCode.getScope(node);
 			const variable = findVariable(scope, node);
 
 			// This was reported https://github.com/sindresorhus/eslint-plugin-unicorn/issues/1075#issuecomment-768072967

diff --git a/rules/consistent-destructuring.js b/rules/consistent-destructuring.js
@@ -53,7 +53,7 @@ const isChildInParentScope = (child, parent) => {
 
 /** @param {import('eslint').Rule.RuleContext} context */
 const create = context => {
-	const sourceCode = context.getSourceCode();
+	const {sourceCode} = context;
 	const declarations = new Map();
 
 	return {

diff --git a/rules/consistent-function-scoping.js b/rules/consistent-function-scoping.js
@@ -149,7 +149,7 @@ function checkNode(node, scopeManager) {
 /** @param {import('eslint').Rule.RuleContext} context */
 const create = context => {
 	const {checkArrowFunctions} = {checkArrowFunctions: true, ...context.options[0]};
-	const sourceCode = context.getSourceCode();
+	const {sourceCode} = context;
 	const {scopeManager} = sourceCode;
 
 	const functions = [];

diff --git a/rules/empty-brace-spaces.js b/rules/empty-brace-spaces.js
@@ -19,7 +19,7 @@ const selector = matches([
 /** @param {import('eslint').Rule.RuleContext} context */
 const create = context => ({
 	[selector](node) {
-		const sourceCode = context.getSourceCode();
+		const {sourceCode} = context;
 		const filter = node.type === 'RecordExpression'
 			? token => token.type === 'Punctuator' && (token.value === '#{' || token.value === '{|')
 			: isOpeningBraceToken;

diff --git a/rules/error-message.js b/rules/error-message.js
@@ -28,7 +28,7 @@ const selector = callOrNewExpressionSelector([
 /** @param {import('eslint').Rule.RuleContext} context */
 const create = context => ({
 	[selector](expression) {
-		const scope = context.getSourceCode().getScope(expression);
+		const scope = context.sourceCode.getScope(expression);
 		if (isShadowed(scope, expression.callee)) {
 			return;
 		}

diff --git a/rules/expiring-todo-comments.js b/rules/expiring-todo-comments.js
@@ -263,7 +263,7 @@ const create = context => {
 		pattern => pattern instanceof RegExp ? pattern : new RegExp(pattern, 'u'),
 	);
 
-	const sourceCode = context.getSourceCode();
+	const {sourceCode} = context;
 	const comments = sourceCode.getAllComments();
 	const unusedComments = comments
 		.filter(token => token.type !== 'Shebang')
@@ -290,7 +290,6 @@ const create = context => {
 			...sourceCode,
 			getAllComments: () => options.allowWarningComments ? [] : unusedComments,
 		},
-		getSourceCode: () => fakeContext.sourceCode,
 	};
 	const rules = baseRule.create(fakeContext);
 

diff --git a/rules/explicit-length-check.js b/rules/explicit-length-check.js
@@ -99,7 +99,7 @@ function create(context) {
 		...context.options[0],
 	};
 	const nonZeroStyle = nonZeroStyles.get(options['non-zero']);
-	const sourceCode = context.getSourceCode();
+	const {sourceCode} = context;
 
 	function getProblem({node, isZeroLengthCheck, lengthNode, autoFix}) {
 		const {code, test} = isZeroLengthCheck ? zeroStyle : nonZeroStyle;

diff --git a/rules/import-style.js b/rules/import-style.js
@@ -167,7 +167,7 @@ const create = context => {
 		),
 	);
 
-	const sourceCode = context.getSourceCode();
+	const {sourceCode} = context;
 
 	const report = (node, moduleName, actualImportStyles, allowedImportStyles, isRequire = false) => {
 		if (!allowedImportStyles || allowedImportStyles.size === 0) {

diff --git a/rules/new-for-builtins.js b/rules/new-for-builtins.js
@@ -49,7 +49,7 @@ function enforceCallExpression({node, path: [name]}, sourceCode) {
 
 /** @param {import('eslint').Rule.RuleContext} context */
 const create = context => {
-	const sourceCode = context.getSourceCode();
+	const {sourceCode} = context;
 	const newExpressionTracker = new GlobalReferenceTracker({
 		objects: builtins.disallowNew,
 		type: GlobalReferenceTracker.CONSTRUCT,

diff --git a/rules/no-array-callback-reference.js b/rules/no-array-callback-reference.js
@@ -174,7 +174,7 @@ function getProblem(context, node, method, options) {
 				parameters: suggestionParameters,
 			},
 			fix(fixer) {
-				const sourceCode = context.getSourceCode();
+				const {sourceCode} = context;
 				let nodeText = sourceCode.getText(node);
 				if (isParenthesized(node, sourceCode) || type === 'ConditionalExpression') {
 					nodeText = `(${nodeText})`;

diff --git a/rules/no-array-for-each.js b/rules/no-array-for-each.js
@@ -80,7 +80,7 @@ function shouldSwitchReturnStatementToBlockStatement(returnStatement) {
 }
 
 function getFixFunction(callExpression, functionInfo, context) {
-	const sourceCode = context.getSourceCode();
+	const {sourceCode} = context;
 	const [callback] = callExpression.arguments;
 	const parameters = callback.params;
 	const iterableObject = callExpression.callee.object;
@@ -386,7 +386,7 @@ const create = context => {
 	const callExpressions = [];
 	const allIdentifiers = [];
 	const functionInfo = new Map();
-	const sourceCode = context.getSourceCode();
+	const {sourceCode} = context;
 
 	return {
 		':function'(node) {

diff --git a/rules/no-array-method-this-argument.js b/rules/no-array-method-this-argument.js
@@ -119,7 +119,7 @@ function useBoundFunction(callExpression, sourceCode) {
 
 /** @param {import('eslint').Rule.RuleContext} context */
 const create = context => {
-	const sourceCode = context.getSourceCode();
+	const {sourceCode} = context;
 
 	return {
 		[selector](callExpression) {

diff --git a/rules/no-array-push-push.js b/rules/no-array-push-push.js
@@ -52,7 +52,7 @@ function create(context) {
 		'process.stderr',
 		...ignore,
 	];
-	const sourceCode = context.getSourceCode();
+	const {sourceCode} = context;
 
 	return {
 		[selector](secondExpression) {

diff --git a/rules/no-await-expression-member.js b/rules/no-await-expression-member.js
@@ -12,7 +12,7 @@ const messages = {
 
 /** @param {import('eslint').Rule.RuleContext} context */
 const create = context => {
-	const sourceCode = context.getSourceCode();
+	const {sourceCode} = context;
 
 	return {
 		'MemberExpression[object.type="AwaitExpression"]'(memberExpression) {

diff --git a/rules/no-console-spaces.js b/rules/no-console-spaces.js
@@ -30,7 +30,7 @@ const hasTrailingSpace = value => value.length > 1 && value.charAt(value.length
 
 /** @param {import('eslint').Rule.RuleContext} context */
 const create = context => {
-	const sourceCode = context.getSourceCode();
+	const {sourceCode} = context;
 	const getProblem = (node, method, position) => {
 		const index = position === 'leading'
 			? node.range[0] + 1

diff --git a/rules/no-empty-file.js b/rules/no-empty-file.js
@@ -29,7 +29,7 @@ const create = context => {
 				return;
 			}
 
-			const sourceCode = context.getSourceCode();
+			const {sourceCode} = context;
 			const comments = sourceCode.getAllComments();
 
 			if (hasTripeSlashDirectives(comments)) {

diff --git a/rules/no-for-loop.js b/rules/no-for-loop.js
@@ -262,7 +262,7 @@ const getReferencesInChildScopes = (scope, name) =>
 
 /** @param {import('eslint').Rule.RuleContext} context */
 const create = context => {
-	const sourceCode = context.getSourceCode();
+	const {sourceCode} = context;
 	const {scopeManager, text: sourceCodeText} = sourceCode;
 
 	return {

diff --git a/rules/no-instanceof-array.js b/rules/no-instanceof-array.js
@@ -18,7 +18,7 @@ const selector = [
 
 /** @param {import('eslint').Rule.RuleContext} context */
 const create = context => {
-	const sourceCode = context.getSourceCode();
+	const {sourceCode} = context;
 
 	return {
 		[selector](node) {

diff --git a/rules/no-invalid-remove-event-listener.js b/rules/no-invalid-remove-event-listener.js
@@ -28,7 +28,7 @@ const create = context => ({
 		if (['ArrowFunctionExpression', 'FunctionExpression'].includes(listener.type)) {
 			return {
 				node: listener,
-				loc: getFunctionHeadLocation(listener, context.getSourceCode()),
+				loc: getFunctionHeadLocation(listener, context.sourceCode),
 				messageId: MESSAGE_ID,
 			};
 		}

diff --git a/rules/no-lonely-if.js b/rules/no-lonely-if.js
@@ -122,7 +122,7 @@ function fix(innerIfStatement, sourceCode) {
 
 /** @param {import('eslint').Rule.RuleContext} context */
 const create = context => {
-	const sourceCode = context.getSourceCode();
+	const {sourceCode} = context;
 
 	return {
 		[selector](node) {

diff --git a/rules/no-negated-condition.js b/rules/no-negated-condition.js
@@ -89,7 +89,7 @@ const create = context => ({
 			messageId: MESSAGE_ID,
 			/** @param {import('eslint').Rule.RuleFixer} fixer */
 			* fix(fixer) {
-				const sourceCode = context.getSourceCode();
+				const {sourceCode} = context;
 				yield * convertNegatedCondition(fixer, node, sourceCode);
 				yield * swapConsequentAndAlternate(fixer, node, sourceCode);
 

diff --git a/rules/no-nested-ternary.js b/rules/no-nested-ternary.js
@@ -12,7 +12,7 @@ const nestTernarySelector = level => `:not(ConditionalExpression)${' > Condition
 
 /** @param {import('eslint').Rule.RuleContext} context */
 const create = context => {
-	const sourceCode = context.getSourceCode();
+	const {sourceCode} = context;
 
 	return {
 		[nestTernarySelector(3)]: node =>

diff --git a/rules/no-new-array.js b/rules/no-new-array.js
@@ -28,7 +28,7 @@ function getProblem(context, node) {
 
 	const [argumentNode] = node.arguments;
 
-	const sourceCode = context.getSourceCode();
+	const {sourceCode} = context;
 	let text = sourceCode.getText(argumentNode);
 	if (isParenthesized(argumentNode, sourceCode)) {
 		text = `(${text})`;

diff --git a/rules/no-new-buffer.js b/rules/no-new-buffer.js
@@ -52,7 +52,7 @@ function fix(node, sourceCode, method) {
 
 /** @param {import('eslint').Rule.RuleContext} context */
 const create = context => {
-	const sourceCode = context.getSourceCode();
+	const {sourceCode} = context;
 	return {
 		[newExpressionSelector('Buffer')](node) {
 			const method = inferMethod(node.arguments, sourceCode.getScope(node));

diff --git a/rules/no-process-exit.js b/rules/no-process-exit.js
@@ -31,7 +31,7 @@ const processExitCallSelector = methodCallSelector({
 
 /** @param {import('eslint').Rule.RuleContext} context */
 const create = context => {
-	const startsWithHashBang = context.getSourceCode().lines[0].indexOf('#!') === 0;
+	const startsWithHashBang = context.sourceCode.lines[0].indexOf('#!') === 0;
 
 	if (startsWithHashBang) {
 		return {};

diff --git a/rules/no-static-only-class.js b/rules/no-static-only-class.js
@@ -197,7 +197,7 @@ function switchClassToObject(node, sourceCode) {
 }
 
 function create(context) {
-	const sourceCode = context.getSourceCode();
+	const {sourceCode} = context;
 
 	return {
 		[selector](node) {

diff --git a/rules/no-thenable.js b/rules/no-thenable.js
@@ -90,7 +90,7 @@ const cases = [
 
 /** @param {import('eslint').Rule.RuleContext} context */
 const create = context => {
-	const sourceCode = context.getSourceCode();
+	const {sourceCode} = context;
 
 	return Object.fromEntries(
 		cases.map(({selector, test, messageId, getNodes}) => [

diff --git a/rules/no-typeof-undefined.js b/rules/no-typeof-undefined.js
@@ -35,7 +35,7 @@ const create = context => {
 		checkGlobalVariables: false,
 		...context.options[0],
 	};
-	const sourceCode = context.getSourceCode();
+	const {sourceCode} = context;
 
 	return {
 		[selector](binaryExpression) {

diff --git a/rules/no-unnecessary-await.js b/rules/no-unnecessary-await.js
@@ -46,7 +46,7 @@ const create = context => ({
 			return;
 		}
 
-		const sourceCode = context.getSourceCode();
+		const {sourceCode} = context;
 		const awaitToken = sourceCode.getFirstToken(node);
 		const problem = {
 			node,

diff --git a/rules/no-unreadable-array-destructuring.js b/rules/no-unreadable-array-destructuring.js
@@ -13,7 +13,7 @@ const isCommaFollowedWithComma = (element, index, array) =>
 
 /** @param {import('eslint').Rule.RuleContext} context */
 const create = context => {
-	const sourceCode = context.getSourceCode();
+	const {sourceCode} = context;
 
 	return {
 		'ArrayPattern[elements.length>=3]'(node) {

diff --git a/rules/no-unreadable-iife.js b/rules/no-unreadable-iife.js
@@ -21,7 +21,7 @@ const selector = [
 /** @param {import('eslint').Rule.RuleContext} context */
 const create = context => ({
 	[selector](node) {
-		const sourceCode = context.getSourceCode();
+		const {sourceCode} = context;
 		if (!isParenthesized(node, sourceCode)) {
 			return;
 		}

diff --git a/rules/no-unused-properties.js b/rules/no-unused-properties.js
@@ -80,7 +80,7 @@ const isUnusedVariable = variable => {
 
 /** @param {import('eslint').Rule.RuleContext} context */
 const create = context => {
-	const sourceCode = context.getSourceCode();
+	const {sourceCode} = context;
 	const getPropertyDisplayName = property => {
 		if (property.key.type === 'Identifier') {
 			return property.key.name;

diff --git a/rules/no-useless-fallback-in-spread.js b/rules/no-useless-fallback-in-spread.js
@@ -34,7 +34,7 @@ const create = context => ({
 			messageId: MESSAGE_ID,
 			/** @param {import('eslint').Rule.RuleFixer} fixer */
 			* fix(fixer) {
-				const sourceCode = context.getSourceCode();
+				const {sourceCode} = context;
 				const logicalExpression = emptyObject.parent;
 				const {left} = logicalExpression;
 				const isLeftObjectParenthesized = isParenthesized(left, sourceCode);

diff --git a/rules/no-useless-length-check.js b/rules/no-useless-length-check.js
@@ -114,7 +114,7 @@ const create = context => {
 					messageId: zeroLengthChecks.has(node) ? 'zero' : 'non-zero',
 					/** @param {import('eslint').Rule.RuleFixer} fixer */
 					fix(fixer) {
-						const sourceCode = context.getSourceCode();
+						const {sourceCode} = context;
 						const {left, right} = node.parent;
 						const leftRange = getParenthesizedRange(left, sourceCode);
 						const rightRange = getParenthesizedRange(right, sourceCode);

diff --git a/rules/no-useless-promise-resolve-reject.js b/rules/no-useless-promise-resolve-reject.js
@@ -173,7 +173,7 @@ function fix(callExpression, isInTryStatement, sourceCode) {
 
 /** @param {import('eslint').Rule.RuleContext} context */
 const create = context => {
-	const sourceCode = context.getSourceCode();
+	const {sourceCode} = context;
 
 	return {
 		[selector](callExpression) {

diff --git a/rules/no-useless-spread.js b/rules/no-useless-spread.js
@@ -186,7 +186,7 @@ function * unwrapSingleArraySpread(fixer, arrayExpression, sourceCode) {
 
 /** @param {import('eslint').Rule.RuleContext} context */
 const create = context => {
-	const sourceCode = context.getSourceCode();
+	const {sourceCode} = context;
 
 	return {
 		[uselessSpreadInListSelector](spreadObject) {

diff --git a/rules/no-useless-switch-case.js b/rules/no-useless-switch-case.js
@@ -43,7 +43,7 @@ const create = context => ({
 		for (const node of uselessCases) {
 			yield {
 				node,
-				loc: getSwitchCaseHeadLocation(node, context.getSourceCode()),
+				loc: getSwitchCaseHeadLocation(node, context.sourceCode),
 				messageId: MESSAGE_ID_ERROR,
 				suggest: [
 					{

diff --git a/rules/no-useless-undefined.js b/rules/no-useless-undefined.js
@@ -108,7 +108,7 @@ const isFunctionBindCall = node =>
 
 /** @param {import('eslint').Rule.RuleContext} context */
 const create = context => {
-	const sourceCode = context.getSourceCode();
+	const {sourceCode} = context;
 
 	const listener = (fix, checkFunctionReturnType) => node => {
 		if (checkFunctionReturnType) {

diff --git a/rules/no-zero-fractions.js b/rules/no-zero-fractions.js
@@ -39,7 +39,7 @@ const create = context => ({
 		// End of fractions
 		const end = node.range[0] + before.length + dotAndFractions.length;
 		const start = end - (raw.length - formatted.length);
-		const sourceCode = context.getSourceCode();
+		const {sourceCode} = context;
 		return {
 			loc: toLocation([start, end], sourceCode),
 			messageId: isDanglingDot ? MESSAGE_DANGLING_DOT : MESSAGE_ZERO_FRACTION,

diff --git a/rules/prefer-add-event-listener.js b/rules/prefer-add-event-listener.js
@@ -137,7 +137,7 @@ const create = context => {
 				&& node.parent.type === 'ExpressionStatement'
 				&& node.parent.expression === node
 			) {
-				fix = fixer => fixCode(fixer, context.getSourceCode(), node, memberExpression);
+				fix = fixer => fixCode(fixer, context.sourceCode, node, memberExpression);
 			}
 
 			return {

diff --git a/rules/prefer-array-find.js b/rules/prefer-array-find.js
@@ -256,7 +256,7 @@ const isDestructuringFirstElement = node => {
 
 /** @param {import('eslint').Rule.RuleContext} context */
 const create = context => {
-	const sourceCode = context.getSourceCode();
+	const {sourceCode} = context;
 	const {
 		checkFromLast,
 	} = {