Add BigInt type to the new-for-builtins rule (#310)

sindresorhus · Jun 3, 2019 · e17f0fd · e17f0fd
1 parent 770fe42
commit e17f0fd
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 0 deletions.
diff --git a/docs/rules/new-for-builtins.md b/docs/rules/new-for-builtins.md
@@ -33,6 +33,7 @@ Disallows the use of `new` for following builtins.
 - `Number`
 - `Boolean`
 - `Symbol`
+- `BigInt`
 
 > These should not use `new` as that would create object wrappers for the primitive values, which is not what you want. However, without `new` they can be useful for coercing a value to that type.
 

diff --git a/rules/new-for-builtins.js b/rules/new-for-builtins.js
@@ -27,6 +27,7 @@ const enforceNew = new Set([
 ]);
 
 const disallowNew = new Set([
+	'BigInt',
 	'Boolean',
 	'Number',
 	'String',

diff --git a/test/new-for-builtins.js b/test/new-for-builtins.js
@@ -43,6 +43,7 @@ ruleTester.run('new-for-builtins', rule, {
 		'const foo = new UInt16Array()',
 		'const foo = new UInt32Array()',
 		'const foo = new Uint8ClampedArray()',
+		'const foo = BigInt()',
 		'const foo = Boolean()',
 		'const foo = Number()',
 		'const foo = String()',
@@ -169,6 +170,11 @@ ruleTester.run('new-for-builtins', rule, {
 			errors: [enforceNewError('Uint8ClampedArray')],
 			output: 'const foo = new Uint8ClampedArray()'
 		},
+		{
+			code: 'const foo = new BigInt(123)',
+			errors: [disallowNewError('BigInt')],
+			output: 'const foo = BigInt(123)'
+		},
 		{
 			code: 'const foo = new Boolean()',
 			errors: [disallowNewError('Boolean')],