Skip to content

Commit

Permalink
Add more TODO tests
Browse files Browse the repository at this point in the history
  • Loading branch information
fisker committed Feb 12, 2020
1 parent e805cf8 commit efd573e
Showing 1 changed file with 11 additions and 1 deletion.
12 changes: 11 additions & 1 deletion test/prefer-node-remove.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ import rule from '../rules/prefer-node-remove';
const ruleTester = avaRuleTester(test, {
env: {
es6: true
},
parserOptions: {
ecmaVersion: 2020
}
});

Expand Down Expand Up @@ -39,6 +42,7 @@ ruleTester.run('prefer-node-remove', rule, {
'remove()',
'foo.parentNode.removeChild(\'bar\')',
'parentNode.removeChild(undefined)',

// Not `CallExpression`
'new parentNode.removeChild(bar);',
// Not `MemberExpression`
Expand All @@ -52,7 +56,13 @@ ruleTester.run('prefer-node-remove', rule, {
// More or less argument(s)
'parentNode.removeChild(bar, extra);',
'parentNode.removeChild();',
'parentNode.removeChild(...argumentsArray)'
'parentNode.removeChild(...argumentsArray)',

// TODO: support cases bellow, and more
'parentNode.removeChild(some.node)',
'parentNode.removeChild(get.child())',
'const foo = async () => parentNode.removeChild(await getChild())',
'parentNode.removeChild((() => childNode)())'
],
invalid: [
invalidTestCase(
Expand Down

0 comments on commit efd573e

Please sign in to comment.