Update dependencies, fix expiring-todo-comments (#2196)

sindresorhus · Sep 22, 2023 · fa431ff · fa431ff
1 parent 6d15a02
commit fa431ff
Show file tree

Hide file tree

Showing 32 changed files with 61 additions and 56 deletions.
diff --git a/package.json b/package.json
@@ -46,7 +46,7 @@
 		"xo"
 	],
 	"dependencies": {
-		"@babel/helper-validator-identifier": "^7.22.5",
+		"@babel/helper-validator-identifier": "^7.22.20",
 		"@eslint-community/eslint-utils": "^4.4.0",
 		"ci-info": "^3.8.0",
 		"clean-regexp": "^1.0.0",
@@ -63,37 +63,37 @@
 		"strip-indent": "^3.0.0"
 	},
 	"devDependencies": {
-		"@babel/code-frame": "^7.22.5",
-		"@babel/core": "^7.22.8",
-		"@babel/eslint-parser": "^7.22.7",
+		"@babel/code-frame": "^7.22.13",
+		"@babel/core": "^7.22.20",
+		"@babel/eslint-parser": "^7.22.15",
 		"@lubien/fixture-beta-package": "^1.0.0-beta.1",
-		"@typescript-eslint/parser": "^6.2.0",
+		"@typescript-eslint/parser": "^6.7.2",
 		"ava": "^3.15.0",
-		"c8": "^8.0.0",
+		"c8": "^8.0.1",
 		"chalk": "^5.3.0",
-		"enquirer": "^2.3.6",
-		"eslint": "^8.44.0",
+		"enquirer": "^2.4.1",
+		"eslint": "^8.49.0",
 		"eslint-ava-rule-tester": "^4.0.0",
 		"eslint-doc-generator": "^1.4.3",
-		"eslint-plugin-eslint-plugin": "^5.1.0",
+		"eslint-plugin-eslint-plugin": "^5.1.1",
 		"eslint-plugin-internal-rules": "file:./scripts/internal-rules/",
 		"eslint-remote-tester": "^3.0.0",
 		"eslint-remote-tester-repositories": "^1.0.1",
-		"execa": "^7.1.1",
+		"execa": "^8.0.1",
 		"listr": "^0.14.3",
 		"lodash-es": "^4.17.21",
-		"markdownlint-cli": "^0.35.0",
+		"markdownlint-cli": "^0.37.0",
 		"mem": "^9.0.2",
 		"npm-package-json-lint": "^7.0.0",
 		"npm-run-all": "^4.1.5",
 		"outdent": "^0.8.0",
-		"typescript": "^5.1.6",
+		"typescript": "^5.2.2",
 		"vue-eslint-parser": "^9.3.1",
-		"xo": "^0.54.2",
-		"yaml": "^2.3.1"
+		"xo": "^0.56.0",
+		"yaml": "^2.3.2"
 	},
 	"peerDependencies": {
-		"eslint": ">=8.44.0"
+		"eslint": ">=8.49.0"
 	},
 	"ava": {
 		"files": [

diff --git a/rules/catch-error-name.js b/rules/catch-error-name.js
@@ -62,7 +62,7 @@ const create = context => {
 
 			if (
 				isNameAllowed(originalName)
-				|| isNameAllowed(originalName.replace(/_+$/g, ''))
+				|| isNameAllowed(originalName.replaceAll(/_+$/g, ''))
 			) {
 				return;
 			}

diff --git a/rules/consistent-destructuring.js b/rules/consistent-destructuring.js
@@ -89,7 +89,7 @@ const create = context => {
 				&& property.key.type === 'Identifier'
 				&& property.value.type === 'Identifier',
 			);
-			const lastProperty = objectPattern.properties[objectPattern.properties.length - 1];
+			const lastProperty = objectPattern.properties.at(-1);
 
 			const hasRest = lastProperty && lastProperty.type === 'RestElement';
 
@@ -134,7 +134,7 @@ const create = context => {
 					},
 					* fix(fixer) {
 						const {properties} = objectPattern;
-						const lastProperty = properties[properties.length - 1];
+						const lastProperty = properties.at(-1);
 
 						yield fixer.replaceText(node, newMember);
 

diff --git a/rules/expiring-todo-comments.js b/rules/expiring-todo-comments.js
@@ -284,13 +284,18 @@ const create = context => {
 	// This is highly dependable on ESLint's `no-warning-comments` implementation.
 	// What we do is patch the parts we know the rule will use, `getAllComments`.
 	// Since we have priority, we leave only the comments that we didn't use.
-	const fakeContext = {
-		...context,
-		sourceCode: {
-			...sourceCode,
-			getAllComments: () => options.allowWarningComments ? [] : unusedComments,
+	const fakeContext = new Proxy(context, {
+		get(target, property, receiver) {
+			if (property === 'sourceCode') {
+				return {
+					...sourceCode,
+					getAllComments: () => options.allowWarningComments ? [] : unusedComments,
+				};
+			}
+
+			return Reflect.get(target, property, receiver);
 		},
-	};
+	});
 	const rules = baseRule.create(fakeContext);
 
 	function processComment(comment) {
@@ -485,7 +490,7 @@ const create = context => {
 				}
 			}
 
-			const withoutWhitespace = unknown.replace(/ /g, '');
+			const withoutWhitespace = unknown.replaceAll(' ', '');
 
 			if (parseArgument(withoutWhitespace).type !== 'unknowns') {
 				uses++;

diff --git a/rules/fix/remove-argument.js b/rules/fix/remove-argument.js
@@ -7,7 +7,7 @@ function removeArgument(fixer, node, sourceCode) {
 	const index = callExpression.arguments.indexOf(node);
 	const parentheses = getParentheses(node, sourceCode);
 	const firstToken = parentheses[0] || node;
-	const lastToken = parentheses[parentheses.length - 1] || node;
+	const lastToken = parentheses.at(-1) || node;
 
 	let [start] = firstToken.range;
 	let [, end] = lastToken.range;

diff --git a/rules/no-array-for-each.js b/rules/no-array-for-each.js
@@ -400,7 +400,7 @@ const create = context => {
 	});
 
 	context.on('ReturnStatement', node => {
-		const currentFunction = functionStack[functionStack.length - 1];
+		const currentFunction = functionStack.at(-1);
 		if (!currentFunction) {
 			return;
 		}

diff --git a/rules/no-array-method-this-argument.js b/rules/no-array-method-this-argument.js
@@ -83,7 +83,7 @@ function useBoundFunction(callExpression, sourceCode) {
 		const callbackParentheses = getParentheses(callback, sourceCode);
 		const isParenthesized = callbackParentheses.length > 0;
 		const callbackLastToken = isParenthesized
-			? callbackParentheses[callbackParentheses.length - 1]
+			? callbackParentheses.at(-1)
 			: callback;
 		if (
 			!isParenthesized

diff --git a/rules/no-console-spaces.js b/rules/no-console-spaces.js
@@ -11,7 +11,7 @@ const messages = {
 const hasLeadingSpace = value => value.length > 1 && value.charAt(0) === ' ' && value.charAt(1) !== ' ';
 
 // Find exactly one trailing space, allow exactly one space
-const hasTrailingSpace = value => value.length > 1 && value.charAt(value.length - 1) === ' ' && value.charAt(value.length - 2) !== ' ';
+const hasTrailingSpace = value => value.length > 1 && value.at(-1) === ' ' && value.at(-2) !== ' ';
 
 /** @param {import('eslint').Rule.RuleContext} context */
 const create = context => {

diff --git a/rules/no-hex-escape.js b/rules/no-hex-escape.js
@@ -8,7 +8,7 @@ const messages = {
 };
 
 function checkEscape(context, node, value) {
-	const fixedValue = value.replace(/(?<=(?:^|[^\\])(?:\\\\)*\\)x/g, 'u00');
+	const fixedValue = value.replaceAll(/(?<=(?:^|[^\\])(?:\\\\)*\\)x/g, 'u00');
 
 	if (value !== fixedValue) {
 		return {

diff --git a/rules/no-unnecessary-await.js b/rules/no-unnecessary-await.js
@@ -30,7 +30,7 @@ function notPromise(node) {
 		}
 
 		case 'SequenceExpression': {
-			return notPromise(node.expressions[node.expressions.length - 1]);
+			return notPromise(node.expressions.at(-1));
 		}
 
 		// No default

diff --git a/rules/no-useless-switch-case.js b/rules/no-useless-switch-case.js
@@ -25,7 +25,7 @@ const create = context => ({
 		const [defaultCase] = defaultCases;
 
 		// We only check cases where the last case is the `default` case
-		if (defaultCase !== cases[cases.length - 1]) {
+		if (defaultCase !== cases.at(-1)) {
 			return;
 		}
 

diff --git a/rules/no-useless-undefined.js b/rules/no-useless-undefined.js
@@ -236,7 +236,7 @@ const create = context => {
 		}
 
 		const firstUndefined = undefinedArguments[0];
-		const lastUndefined = undefinedArguments[undefinedArguments.length - 1];
+		const lastUndefined = undefinedArguments.at(-1);
 
 		return {
 			messageId,

diff --git a/rules/no-zero-fractions.js b/rules/no-zero-fractions.js
@@ -28,7 +28,7 @@ const create = context => ({
 		}
 
 		const {before, dotAndFractions, after} = match.groups;
-		const fixedDotAndFractions = dotAndFractions.replace(/[.0_]+$/g, '');
+		const fixedDotAndFractions = dotAndFractions.replaceAll(/[.0_]+$/g, '');
 		const formatted = ((before + fixedDotAndFractions) || '0') + after;
 
 		if (formatted === raw) {

diff --git a/rules/numeric-separators-style.js b/rules/numeric-separators-style.js
@@ -111,7 +111,7 @@ const create = context => {
 				suffix = 'n';
 			}
 
-			const strippedNumber = number.replace(/_/g, '');
+			const strippedNumber = number.replaceAll('_', '');
 			const {prefix, data} = numeric.getPrefix(strippedNumber);
 
 			const {onlyIfContainsSeparator} = options[prefix.toLowerCase()];

diff --git a/rules/prefer-default-parameters.js b/rules/prefer-default-parameters.js
@@ -72,7 +72,7 @@ const hasExtraReferences = (assignment, references, left) => {
 };
 
 const isLastParameter = (parameters, parameter) => {
-	const lastParameter = parameters[parameters.length - 1];
+	const lastParameter = parameters.at(-1);
 
 	// See 'default-param-last' rule
 	return parameter && parameter === lastParameter;
@@ -122,7 +122,7 @@ const create = context => {
 	const functionStack = [];
 
 	const checkExpression = (node, left, right, assignment) => {
-		const currentFunction = functionStack[functionStack.length - 1];
+		const currentFunction = functionStack.at(-1);
 
 		if (!currentFunction || !isDefaultExpression(left, right)) {
 			return;

diff --git a/rules/prefer-dom-node-dataset.js b/rules/prefer-dom-node-dataset.js
@@ -12,7 +12,7 @@ const messages = {
 	[MESSAGE_ID]: 'Prefer `.dataset` over `{{method}}(…)`.',
 };
 
-const dashToCamelCase = string => string.replace(/-[a-z]/g, s => s[1].toUpperCase());
+const dashToCamelCase = string => string.replaceAll(/-[a-z]/g, s => s[1].toUpperCase());
 
 function getFix(callExpression, context) {
 	const method = callExpression.callee.property.name;

diff --git a/rules/prefer-export-from.js b/rules/prefer-export-from.js
@@ -148,7 +148,7 @@ function getFixFunction({
 			}
 
 			if (exportDeclaration) {
-				const lastSpecifier = exportDeclaration.specifiers[exportDeclaration.specifiers.length - 1];
+				const lastSpecifier = exportDeclaration.specifiers.at(-1);
 
 				// `export {} from 'foo';`
 				if (lastSpecifier) {

diff --git a/rules/prefer-object-from-entries.js b/rules/prefer-object-from-entries.js
@@ -99,7 +99,7 @@ function fixReduceAssignOrSpread({sourceCode, callExpression, property}) {
 		const initObject = callExpression.arguments[1];
 		const parentheses = getParentheses(initObject, sourceCode);
 		const firstToken = parentheses[0] || initObject;
-		const lastToken = parentheses[parentheses.length - 1] || initObject;
+		const lastToken = parentheses.at(-1) || initObject;
 		const startToken = sourceCode.getTokenBefore(firstToken);
 		const [start] = startToken.range;
 		const [, end] = lastToken.range;

diff --git a/rules/prefer-query-selector.js b/rules/prefer-query-selector.js
@@ -18,7 +18,7 @@ const getReplacementForClass = value => value.match(/\S+/g).map(className => `.$
 
 const getQuotedReplacement = (node, value) => {
 	const leftQuote = node.raw.charAt(0);
-	const rightQuote = node.raw.charAt(node.raw.length - 1);
+	const rightQuote = node.raw.at(-1);
 	return `${leftQuote}${value}${rightQuote}`;
 };
 

diff --git a/rules/prefer-spread.js b/rules/prefer-spread.js
@@ -74,7 +74,7 @@ function fixConcat(node, sourceCode, fixableArguments) {
 	const getFixedText = () => {
 		const nonEmptyArguments = fixableArguments
 			.filter(({node, isArrayLiteral}) => (!isArrayLiteral || node.elements.length > 0));
-		const lastArgument = nonEmptyArguments[nonEmptyArguments.length - 1];
+		const lastArgument = nonEmptyArguments.at(-1);
 
 		let text = nonEmptyArguments
 			.map(({node, isArrayLiteral, isSpreadable, testArgument}) => {

diff --git a/rules/prefer-switch.js b/rules/prefer-switch.js
@@ -191,7 +191,7 @@ function fix({discriminant, ifStatements}, sourceCode, options) {
 		const indent = getIndentString(firstStatement, sourceCode);
 		yield fixer.insertTextBefore(firstStatement, `switch (${discriminantText}) {`);
 
-		const lastStatement = ifStatements[ifStatements.length - 1].statement;
+		const lastStatement = ifStatements.at(-1).statement;
 		if (lastStatement.alternate) {
 			const {alternate} = lastStatement;
 			yield fixer.insertTextBefore(alternate, `\n${indent}default: `);

diff --git a/rules/template-indent.js b/rules/template-indent.js
@@ -79,7 +79,7 @@ const create = context => {
 		}
 
 		const dedented = stripIndent(joined);
-		const trimmed = dedented.replace(new RegExp(`^${eol}|${eol}[ \t]*$`, 'g'), '');
+		const trimmed = dedented.replaceAll(new RegExp(`^${eol}|${eol}[ \t]*$`, 'g'), '');
 
 		const fixed
 			= eol

diff --git a/rules/utils/escape-template-element-raw.js b/rules/utils/escape-template-element-raw.js
@@ -1,6 +1,6 @@
 'use strict';
 
-module.exports = string => string.replace(
+module.exports = string => string.replaceAll(
 	/(?<=(?:^|[^\\])(?:\\\\)*)(?<symbol>(?:`|\$(?={)))/g,
 	'\\$<symbol>',
 );
diff --git a/rules/utils/is-number.js b/rules/utils/is-number.js
@@ -209,7 +209,7 @@ function isNumber(node, scope) {
 		}
 
 		case 'SequenceExpression': {
-			if (isNumber(node.expressions[node.expressions.length - 1], scope)) {
+			if (isNumber(node.expressions.at(-1), scope)) {
 				return true;
 			}
 

diff --git a/rules/utils/parentheses.js b/rules/utils/parentheses.js
@@ -48,7 +48,7 @@ Get the parenthesized range of the node.
 function getParenthesizedRange(node, sourceCode) {
 	const parentheses = getParentheses(node, sourceCode);
 	const [start] = (parentheses[0] || node).range;
-	const [, end] = (parentheses[parentheses.length - 1] || node).range;
+	const [, end] = (parentheses.at(-1) || node).range;
 	return [start, end];
 }
 

diff --git a/scripts/create-rule.mjs b/scripts/create-rule.mjs
@@ -55,7 +55,7 @@ function updateRecommended(id) {
 	let insertIndex;
 	if (ruleContent.localeCompare(unicornRuleLines[0]) === -1) {
 		insertIndex = 0;
-	} else if (ruleContent.localeCompare(unicornRuleLines[unicornRuleLines.length - 1]) === 1) {
+	} else if (ruleContent.localeCompare(unicornRuleLines.at(-1)) === 1) {
 		insertIndex = lines.length;
 		lines[lines.length - 1] += ',';
 		ruleContent = ruleContent.slice(0, -1);

diff --git a/test/expiring-todo-comments.mjs b/test/expiring-todo-comments.mjs
@@ -35,7 +35,7 @@ const avoidMultiplePackageVersionsError = (versions, message) => ({
 });
 
 const removeWhitespaceError = (argument, message) => ({
-	message: `Avoid using whitespace on TODO argument. On '${argument}' use '${argument.replace(/ /g, '')}'. ${message}`,
+	message: `Avoid using whitespace on TODO argument. On '${argument}' use '${argument.replaceAll(' ', '')}'. ${message}`,
 });
 
 const missingAtSymbolError = (bad, good, message) => ({

diff --git a/test/package.mjs b/test/package.mjs
@@ -135,7 +135,7 @@ test('validate configuration', async t => {
 		const recommendedEnvironments = Object.keys(eslintPluginUnicorn.configs.recommended.env);
 		t.is(recommendedEnvironments.length, 1);
 		t.is(
-			availableEnvironments[availableEnvironments.length - 1],
+			availableEnvironments.at(-1),
 			recommendedEnvironments[0],
 			'env should be the latest es version',
 		);

diff --git a/test/prefer-modern-math-apis.mjs b/test/prefer-modern-math-apis.mjs
@@ -7,7 +7,7 @@ const {test} = getTester(import.meta);
 const duplicateLog10Test = code => [
 	code,
 	// `Math.log2()` test
-	code.replace(/Math\.LOG10E/g, 'Math.LOG2E').replace(/Math\.LN10/g, 'Math.LN2'),
+	code.replaceAll('Math.LOG10E', 'Math.LOG2E').replaceAll('Math.LN10', 'Math.LN2'),
 ];
 test.snapshot({
 	valid: [

diff --git a/test/prefer-ternary.mjs b/test/prefer-ternary.mjs
@@ -523,13 +523,13 @@ test({
 															throw new TypeError('a');
 														}
 				}
-			`.replace(/\t/g, '  '),
+			`.replaceAll('\t', '  '),
 			output: outdent`
 				function unicorn() {
 														const error = test ? new Error('a') : new TypeError('a');
 														throw error;
 				}
-			`.replace(/\t/g, '  '),
+			`.replaceAll('\t', '  '),
 			errors,
 		},
 		{

diff --git a/test/template-indent.mjs b/test/template-indent.mjs
@@ -9,8 +9,8 @@ import {getTester} from './utils/test.mjs';
  * @param {string} text
  */
 const fixInput = text => stripIndent(text)
-	.replace(/•/g, ' ')
-	.replace(/→→/g, '\t');
+	.replaceAll('•', ' ')
+	.replaceAll('→→', '\t');
 
 const {test} = getTester(import.meta);
 

diff --git a/test/utils/snapshot-rule-tester.mjs b/test/utils/snapshot-rule-tester.mjs
@@ -41,7 +41,7 @@ function visualizeEslintMessage(text, result) {
 
 const printCode = code => codeFrameColumns(code, {start: {line: 0, column: 0}}, codeFrameColumnsOptions);
 const INDENT = ' '.repeat(4);
-const indentCode = code => code.replace(/^/gm, INDENT);
+const indentCode = code => code.replaceAll(/^/gm, INDENT);
 const getAdditionalProperties = (object, properties) =>
 	Object.keys(object).filter(property => !properties.includes(property));