Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The regex-shorthand rule has a false-negative #157

Closed
sindresorhus opened this issue Feb 15, 2018 · 3 comments · Fixed by #437
Closed

The regex-shorthand rule has a false-negative #157

sindresorhus opened this issue Feb 15, 2018 · 3 comments · Fixed by #437
Labels
bug 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted

Comments

@sindresorhus
Copy link
Owner

sindresorhus commented Feb 15, 2018

Issuehunt badges

This doesn't cause a lint error:

const foo = /^by @([a-zA-Z0-9-]+)/

Even though it could be:

const foo = /^by @([a-zA-Z\d-]+)/

I think we might need to use some more advanced detection. Maybe regexp-tree. Although, it has an optimizer API already, which I think already handles this and many other cases.

// @SamVerschueren


IssueHunt Summary

jdanil jdanil has been rewarded.

Backers (Total: $30.00)

Submitted pull Requests


Tips


IssueHunt has been backed by the following sponsors. Become a sponsor

@IssueHuntBot
Copy link

@IssueHunt has funded $30.00 to this issue.


Manu1400 added a commit to Manu1400/eslint-plugin-unicorn that referenced this issue Mar 24, 2019
Manu1400 added a commit to Manu1400/eslint-plugin-unicorn that referenced this issue Mar 24, 2019
@issuehunt-oss issuehunt-oss bot added the 💵 Funded on Issuehunt This issue has been funded on Issuehunt label May 10, 2019
@sindresorhus
Copy link
Owner Author

This is up for grabs again. If anyone wants to tackle this, you can probably continue where #261 left off.

@issuehunt-oss
Copy link

issuehunt-oss bot commented Nov 24, 2019

@sindresorhus has rewarded $27.00 to @jdanil. See it on IssueHunt

  • 💰 Total deposit: $30.00
  • 🎉 Repository reward(0%): $0.00
  • 🔧 Service fee(10%): $3.00

@issuehunt-oss issuehunt-oss bot added 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt and removed 💵 Funded on Issuehunt This issue has been funded on Issuehunt labels Nov 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted
Projects
None yet
2 participants