Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rule proposal: No zero fractions #207

Closed
sindresorhus opened this issue Jan 11, 2019 · 7 comments · Fixed by #244
Closed

Rule proposal: No zero fractions #207

sindresorhus opened this issue Jan 11, 2019 · 7 comments · Fixed by #244
Labels
enhancement 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted

Comments

@sindresorhus
Copy link
Owner

sindresorhus commented Jan 11, 2019

Issuehunt badges

There are no difference between 1 and 1.0 in JS. For consistency, the former should be preferred.

Fail

console.log(1.0 + 5.0);
console.log(3.00000000);

Pass

console.log(1 + 5);
console.log(3);
console.log(7.0000001);

stroncium earned $60.00 by resolving this issue!

@sindresorhus
Copy link
Owner Author

Accepted. PR welcome :)

@IssueHuntBot
Copy link

@issuehuntfest has funded $60.00 to this issue. See it on IssueHunt

@arshadkazmi42
Copy link

@sindresorhus I would like to take this.

@rahgurung
Copy link

@arshadkazmi42 I have already started the work :)

@arshadkazmi42
Copy link

@gurungrahul2 ok. thanks for information 👍

stroncium added a commit to stroncium/eslint-plugin-unicorn that referenced this issue Feb 6, 2019
stroncium added a commit to stroncium/eslint-plugin-unicorn that referenced this issue Feb 6, 2019
stroncium added a commit to stroncium/eslint-plugin-unicorn that referenced this issue Feb 6, 2019
@stroncium
Copy link
Contributor

Sorry about triple reference, didn't know github added cross-repo referencing, consider only the last one.

stroncium added a commit to stroncium/eslint-plugin-unicorn that referenced this issue Feb 11, 2019
stroncium added a commit to stroncium/eslint-plugin-unicorn that referenced this issue Feb 27, 2019
sindresorhus pushed a commit that referenced this issue Mar 23, 2019
@IssueHuntBot
Copy link

@sindresorhus has rewarded $54.00 to @stroncium. See it on IssueHunt

  • 💰 Total deposit: $60.00
  • 🎉 Repository reward(0%): $0.00
  • 🔧 Service fee(10%): $6.00

@issuehunt-oss issuehunt-oss bot added the 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt label May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants