Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use AST selector for no-new-buffer rule #101

Merged
merged 2 commits into from
Jul 11, 2017

Conversation

SamVerschueren
Copy link
Contributor

Looks cleaner with a selector.

@jfmengels
Copy link
Contributor

You're right, it looks better with selectors. But the plugin currently has a peer dependency to ESLint >= 3.6, whereas AST selectors landed in ESLint 3.18.0. So landing this would break this rule for any projects using ESLint < 3.18.0 :/

@sindresorhus
Copy link
Owner

@SamVerschueren Can you bump the peerDependency to ESLint v4? We'll have to do a major version anyways (because of new default rules).

@SamVerschueren
Copy link
Contributor Author

Done

@sindresorhus sindresorhus merged commit d027a28 into sindresorhus:master Jul 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants