[DO NOT MERGE] Auto fix prefer-destructuring-in-parameters on codebase
#1046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sindresorhus
requested changes
Jan 22, 2021
| @@ -98,8 +98,8 @@ const create = context => { | |||
| const member = source.getText(node.property); | |||
|
|
|||
| // Member might already be destructured | |||
| const destructuredMember = destructurings.find(property => | |||
| property.key.name === member | |||
| const destructuredMember = destructurings.find(({key}) => | |||
There was a problem hiding this comment.
The problem with destructuring is that you lose some readability information. It's no longer clear when you read this that key is the key of a property...
| scope.block && | ||
| scope.block.type === 'ArrowFunctionExpression' && | ||
| (scope.thisFound || scope.childScopes.some(scope => isArrowFunctionWithThis(scope))); | ||
| const isReactHook = ({block}) => |
There was a problem hiding this comment.
It's no longer possible to infer from the function what type it supports (that it supports a scope...
Comment on lines
+100
to
+104
| const isArrowFunctionWithThis = ({type, block, thisFound, childScopes}) => | ||
| type === 'function' && | ||
| block && | ||
| block.type === 'ArrowFunctionExpression' && | ||
| (thisFound || childScopes.some(scope => isArrowFunctionWithThis(scope))); |
There was a problem hiding this comment.
I think the previous version was more readable, and not much longer.
|
Gonna close this for now as it's uncertain what we'll do with this rule. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes a lot, I'd like to fix codebase after #1045 get merged.