Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prefer-array-includes rule #1059

Closed
wants to merge 87 commits into from
Closed

Add prefer-array-includes rule #1059

wants to merge 87 commits into from

Conversation

Fabrice-TIERCELIN
Copy link
Contributor

Add prefer-indexof rule

I didn't write the snapshot test as I don't know how to get the file .js.snap.

Fixes #1058

fisker and others added 30 commits January 24, 2021 07:08
@fisker @Fabrice-TIERCELIN
prevent-abbreviations: Fix crash with TypeScript parser (#913)
b55c745
@fisker @Fabrice-TIERCELIN
error-message: Check AggregateError too (#921)
1c88f0a
@futpib @fisker @Fabrice-TIERCELIN
Fix false import styles seen in reported problem messages (#910)
44d7117 
Co-authored-by: fisker Cheung <lionkay@gmail.com>
@fisker @Fabrice-TIERCELIN
Update ava, remove index prefix for snapshots (#926)
c259f18
@fisker @Fabrice-TIERCELIN
Revert "error-message: Check AggregateError too (#921)" (#925)
f0cab4f 
* Revert "`error-message`: Check `AggregateError` too (#921)"

This reverts commit 08ddc78.

* Update error-message.js
@fisker @Fabrice-TIERCELIN
import-style: Fix crash on babel-eslint parser (#927)
b306f01
@fisker @Fabrice-TIERCELIN
Fix integration test (#914)
de776fe
@fisker @Fabrice-TIERCELIN
Update dependencies (#928)
bc0354f
@fisker @Fabrice-TIERCELIN
Update .snap files (#929)
7a3ad35
@fisker @Fabrice-TIERCELIN
Rewrite error-message rule (#922)
c9410d4
@fisker @Fabrice-TIERCELIN
prevent-abbreviations: Add ignore option (#891)
f619f3a
@fisker @Fabrice-TIERCELIN
consistent-function-scoping: Allow ignoring arrow functions (#932)
881f573
@fisker @Fabrice-TIERCELIN
Update create-rule script to allow choosing fixable "whitespace" (#934
079acfc 
)
@fisker @Fabrice-TIERCELIN
Add prefer-date-now rule (#935)
7c27a23
@fisker @Fabrice-TIERCELIN
prefer-ternary: Refactor to use ESLint recommended way to extend fi…
3228c39 
…x range (#857)
@fisker @Fabrice-TIERCELIN
Add empty-brace-spaces rule (#933)
1e1b0e2
@AriPerkkio @Fabrice-TIERCELIN
Adds weekly scheduled smoke tests (#923)
fccbdea
@fisker @sindresorhus @Fabrice-TIERCELIN
Add no-lonely-if rule (#936)
4c4ab32 
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
@sindresorhus @Fabrice-TIERCELIN
Update dev dependencies
bb3168f
@sindresorhus @Fabrice-TIERCELIN
24.0.0
756283b
@FloEdelmann @Fabrice-TIERCELIN
Fix link in new-for-builtins rule documentation (#939)
2912ef5 
* Fix link in `new-for-builtins` rule documentation

* Fix typo
@fisker @Fabrice-TIERCELIN
Rewrite explicit-length-check rule (#938)
fcdf75c
@medusalix @fisker
@sindresorhus @Fabrice-TIERCELIN
Add prefer-default-parameters rule (#632)
c60da35 
Co-authored-by: fisker <lionkay@gmail.com>
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
@sindresorhus @Fabrice-TIERCELIN
Improve internal naming
7941252
@fisker @Fabrice-TIERCELIN
explicit-length-check: Check more cases (#941)
724ca3e
@jdanil @Fabrice-TIERCELIN
prefer-date-now: Elaborate on rule rationale (#946)
c2a81c5
@fisker @Fabrice-TIERCELIN
no-unreadable-array-destructuring: Update tests (#947)
de8c095
@fisker @Fabrice-TIERCELIN
new-for-builtins: Ignore Object(x) === x and Object(x) !== x (#944
baba293 
)
@fisker @Fabrice-TIERCELIN
explicit-length-check: Make rule work in many more cases (#943)
597d42a
@fisker @Fabrice-TIERCELIN
Refactor explicit-length-check (#950)
c5406e2
fisker and others added 25 commits January 24, 2021 07:08
@fisker @Fabrice-TIERCELIN
no-keyword-prefix: Add some test (#1023)
c5db0a2
@fisker @sindresorhus @Fabrice-TIERCELIN
Add no-this-assignment rule (#1018)
cbed6ef 
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
@fisker @Fabrice-TIERCELIN
Better fix for new-for-builtins (#1022)
903ade6
@Yash-Singh1 @Fabrice-TIERCELIN
Fix no-array-reduce code example (#1026)
830f70d
@fisker @Fabrice-TIERCELIN
prefer-spread: Refactor tests (#1028)
211fa24
@Cherry @Fabrice-TIERCELIN
better-regexp: bump regexp-tree dependency (#1031)
1a23d31
@fisker @Fabrice-TIERCELIN
Tweaks (#1033)
5210aed
@fisker @Fabrice-TIERCELIN
prefer-query-selector: Fix crash on unexpected selector (#1034)
423b7d0
@fisker @sindresorhus
@noftaly @Fabrice-TIERCELIN
prefer-ternary: Add only-single-line option (#1025)
13a051b 
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
Co-authored-by: Elliot <elliot@maisl.fr>
@fisker @Fabrice-TIERCELIN
Add no-array-for-each rule (#1017)
5404649
@fisker @Fabrice-TIERCELIN
Fix isLiteralValue (#1035)
0305daa
@noftaly @sindresorhus
@fisker @Fabrice-TIERCELIN
numeric-separators-style: Add checkOnlyIfSeparator option (#916)
fef5359 
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
Co-authored-by: fisker <lionkay@gmail.com>
@fisker @sindresorhus @Fabrice-TIERCELIN
prefer-spread: Prefer ... over Array#concat() (#1029)
6e89fca 
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
@fisker @Fabrice-TIERCELIN
Refactor: replace isSameNode with hasSameRange (#1036)
33d6a4e
@fisker @Fabrice-TIERCELIN
no-array-for-each: Fix broken auto-fixed code (#1039)
4192eed
@fisker @Fabrice-TIERCELIN
no-new-buffer: Use suggestion for unknown arguments (#1037)
7d0d8ff
@fisker @Fabrice-TIERCELIN
Use @babel/eslint-parser in tests (#961)
f59f758
@fisker @Fabrice-TIERCELIN
no-array-for-each: Add auto-fix for some wrongly detected case (#1043)
9ecb25f
@fisker @Fabrice-TIERCELIN
no-array-callback-reference: Improve suggestions for `Array#forEach…
9359743 
…()` (#1049)
@fisker @sindresorhus @Fabrice-TIERCELIN
Refactor: remove eslint-ast-utils package (#1048)
8d6c4e3 
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
@fisker @sindresorhus @Fabrice-TIERCELIN
prefer-spread: Fix more .concat cases (#1042)
f44d128 
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
@sindresorhus @Fabrice-TIERCELIN
27.0.0
2b29771
@fisker @Fabrice-TIERCELIN
Switch default branch to main (#1056)
958cb25
@Fabrice-TIERCELIN
Add prefer-array-index-of rule (#11)
b33b406 
Add `prefer-array-index-of` rule
@Fabrice-TIERCELIN
Merge branch 'main' into prefer-array-includes
3ade543
@fisker
Copy link
Collaborator

fisker commented Jan 24, 2021 •
edited

Closing this, see #1058 (comment), please pull main branch from upstream, and start from there, too many unrelated commits in this PR.

Update/create snapshot, use npx ava -u or npx ava test/xxxx.js -u.

@fisker fisker closed this Jan 24, 2021
@fisker fisker changed the title Add prefer-array-index-of rule Add prefer-array-includes rule Jan 24, 2021
@Fabrice-TIERCELIN Fabrice-TIERCELIN deleted the prefer-array-includes branch January 24, 2021 16:26
@yakov116 yakov116 mentioned this pull request Jan 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rule proposal: prefer-array-includes