Add prefer-module rule

[fisker]

Fixes #1067

[fisker]

I'm almost done here, questions:

1. Should we ignore .cjs file? Or let user to choose?
2. I used suggestion instead of auto-fix, I think all these fix breaks code. (expect removing "use strict"), WDYT?
3. Anything missing?

[fisker]

@sindresorhus ^

[sindresorhus]

Should we also enforce using "type": "module" in package.json?

[sindresorhus]

1. I would not. We could publish and see if someone opens an issue requesting it before we add an option.
2. Makes sense. Even use strict is not technically safe to remove as it can change semantics if not in an ESM context, as it then makes the code non-strict.
3. I think you covered it all.

[fisker]

Even use strict is not technically safe to remove as

You are right, but it most likely not going to cause problem, let's keep it this way for now.

[fisker]

Should we also enforce using "type": "module" in package.json?

I don't think so, package.json self is not JavaScript file, it will not be linted normally, and if we report this problem in a .js file seems weird.

[fisker]

Maybe we can create eslint-plugin-package-json 😄

[sindresorhus]

Maybe we can create eslint-plugin-package-json 😄

I think it's too much work to maintain a plugin just for that. How about an opt-in package-json rule in this repo?

[sindresorhus]

I pushed some docs improvements.

[sindresorhus]

Did you implement #1067 (comment)?

[fisker]

Yes, all access of global require, module, and exports are reported.

https://github.com/sindresorhus/eslint-plugin-unicorn/pull/1141/files#diff-13455d67606e537047e216aceb85af848608cfa605ddcbb5e1c4f0c55c15f076R261

https://github.com/sindresorhus/eslint-plugin-unicorn/pull/1141/files#diff-13455d67606e537047e216aceb85af848608cfa605ddcbb5e1c4f0c55c15f076R1276

https://github.com/sindresorhus/eslint-plugin-unicorn/pull/1141/files#diff-13455d67606e537047e216aceb85af848608cfa605ddcbb5e1c4f0c55c15f076R1296

[sindresorhus]

Awesome!

[yoyo837]

Excuse me, How can i disable this rule in nodejs code file? For example, webpack config files.

[fisker]

{
	overrides: [
		{
			files: [],
			rules: {
				'unicorn/prefer-module': 'off'
			}
		}
	]
}

https://eslint.org/docs/user-guide/configuring/configuration-files#configuration-based-on-glob-patterns

[yoyo837]

Thanks.