Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no-keyword-prefix: Rename blacklist option to disallowedPrefixes #1180

Merged
merged 2 commits into from
Apr 14, 2021
Merged

no-keyword-prefix: Rename blacklist option to disallowedPrefixes #1180

merged 2 commits into from
Apr 14, 2021

Conversation

fisker
Copy link
Collaborator

@fisker fisker commented Apr 14, 2021

Fixes #942

@sindresorhus
Copy link
Owner

I don't think keywords is the correct naming here. It does describe the default values, but not the intent of the option. The prefix could be for anything, not just keywords. How about disallowedPrefixes?

@fisker fisker changed the title no-keyword-prefix: Rename blacklist to keywords no-keyword-prefix: Rename blacklist to disallowedPrefixes Apr 14, 2021
@sindresorhus sindresorhus changed the title no-keyword-prefix: Rename blacklist to disallowedPrefixes no-keyword-prefix: Rename blacklist option to disallowedPrefixes Apr 14, 2021
@sindresorhus sindresorhus merged commit 91e60d0 into sindresorhus:main Apr 14, 2021
@fisker fisker deleted the no-keyword-prefix-options branch April 15, 2021 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve option naming
2 participants
@fisker @sindresorhus